]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
Fix memory leak in ntlm_support
authorFrank Lichtenheld <frank@lichtenheld.com>
Mon, 9 Dec 2024 19:49:57 +0000 (20:49 +0100)
committerGert Doering <gert@greenie.muc.de>
Mon, 9 Dec 2024 20:06:14 +0000 (21:06 +0100)
Not really important but prevents running the NTLM
t_client tests with ASAN enabled.

Change-Id: If472398d4ff8323de485f084a07160b365dfc501
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Lev Stipakov <lstipakov@gmail.com>
Message-Id: <20241209194957.358-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30049.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
tests/ntlm_support.c

index ccf896244964738fe77497fa26cba5c01b246762..18d555ab3bf3fe1a8846d6c8afd76abbc4beaa1b 100644 (file)
 int
 main(void)
 {
+#ifdef NTLM
 #if defined(ENABLE_CRYPTO_OPENSSL)
-    crypto_load_provider("legacy");
-    crypto_load_provider("default");
+    provider_t *legacy = crypto_load_provider("legacy");
+    provider_t *def = crypto_load_provider("default");
 #endif
-#ifdef NTLM
     if (!md_valid("MD4"))
     {
         msg(M_FATAL, "MD4 not supported");
@@ -46,6 +46,10 @@ main(void)
     {
         msg(M_FATAL, "MD5 not supported");
     }
+#if defined(ENABLE_CRYPTO_OPENSSL)
+    crypto_unload_provider("legacy", legacy);
+    crypto_unload_provider("default", def);
+#endif
 #else  /* ifdef NTLM */
     msg(M_FATAL, "NTLM support not compiled in");
 #endif