]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: vertexcom: mse102x: Drop invalid cmd stats
authorStefan Wahren <wahrenst@gmx.net>
Fri, 9 May 2025 12:04:32 +0000 (14:04 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 13 May 2025 01:46:44 +0000 (18:46 -0700)
There are several reasons for an invalid command response
by the MSE102x:
* SPI line interferences
* MSE102x is in reset or has no firmware
* MSE102x is busy
* no packet in MSE102x receive buffer

So the counter for invalid command isn't very helpful without
further context. So drop the confusing statistics counter,
but keep the debug messages about "unexpected response" in order
to debug possible hardware issues.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250509120435.43646-4-wahrenst@gmx.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/vertexcom/mse102x.c

index 78a50a68c567778cfd347061fbce8b4b29f6e277..954256fddd7c48b663d5ef7628d24488609d902e 100644 (file)
@@ -46,7 +46,6 @@
 
 struct mse102x_stats {
        u64 xfer_err;
-       u64 invalid_cmd;
        u64 invalid_ctr;
        u64 invalid_dft;
        u64 invalid_len;
@@ -57,7 +56,6 @@ struct mse102x_stats {
 
 static const char mse102x_gstrings_stats[][ETH_GSTRING_LEN] = {
        "SPI transfer errors",
-       "Invalid command",
        "Invalid CTR",
        "Invalid DFT",
        "Invalid frame length",
@@ -195,7 +193,6 @@ static int mse102x_rx_cmd_spi(struct mse102x_net *mse, u8 *rxb)
        } else if (*cmd != cpu_to_be16(DET_CMD)) {
                net_dbg_ratelimited("%s: Unexpected response (0x%04x)\n",
                                    __func__, *cmd);
-               mse->stats.invalid_cmd++;
                ret = -EIO;
        } else {
                memcpy(rxb, trx + 2, 2);