]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ceph: Remove osd_client deadcode
authorDr. David Alan Gilbert <linux@treblig.org>
Sat, 22 Feb 2025 01:35:30 +0000 (01:35 +0000)
committerIlya Dryomov <idryomov@gmail.com>
Thu, 3 Apr 2025 19:35:32 +0000 (21:35 +0200)
osd_req_op_extent_osd_data_pagelist() was added in 2013 as part of
commit a4ce40a9a7c1 ("libceph: combine initializing and setting osd data")
but never used.

The last use of osd_req_op_cls_request_data_pagelist() was removed in
2017's commit ecd4a68a26a2 ("rbd: switch rbd_obj_method_sync() to
ceph_osdc_call()")

Remove them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
include/linux/ceph/osd_client.h
net/ceph/osd_client.c

index d55b30057a4555fdae870f9ad245eba7fe93bba0..50b14a5661c7a41593e8316e4f832ce7ff7fd25b 100644 (file)
@@ -490,9 +490,6 @@ extern void osd_req_op_extent_osd_data_pages(struct ceph_osd_request *,
                                        struct page **pages, u64 length,
                                        u32 alignment, bool pages_from_pool,
                                        bool own_pages);
-extern void osd_req_op_extent_osd_data_pagelist(struct ceph_osd_request *,
-                                       unsigned int which,
-                                       struct ceph_pagelist *pagelist);
 #ifdef CONFIG_BLOCK
 void osd_req_op_extent_osd_data_bio(struct ceph_osd_request *osd_req,
                                    unsigned int which,
@@ -509,9 +506,6 @@ void osd_req_op_extent_osd_data_bvec_pos(struct ceph_osd_request *osd_req,
 void osd_req_op_extent_osd_iter(struct ceph_osd_request *osd_req,
                                unsigned int which, struct iov_iter *iter);
 
-extern void osd_req_op_cls_request_data_pagelist(struct ceph_osd_request *,
-                                       unsigned int which,
-                                       struct ceph_pagelist *pagelist);
 extern void osd_req_op_cls_request_data_pages(struct ceph_osd_request *,
                                        unsigned int which,
                                        struct page **pages, u64 length,
index b24afec241382b60d775dd12a6561fa23a7eca45..6664ea73ccf81b12199142b92bddde8a2ed471e4 100644 (file)
@@ -220,16 +220,6 @@ void osd_req_op_extent_osd_data_pages(struct ceph_osd_request *osd_req,
 }
 EXPORT_SYMBOL(osd_req_op_extent_osd_data_pages);
 
-void osd_req_op_extent_osd_data_pagelist(struct ceph_osd_request *osd_req,
-                       unsigned int which, struct ceph_pagelist *pagelist)
-{
-       struct ceph_osd_data *osd_data;
-
-       osd_data = osd_req_op_data(osd_req, which, extent, osd_data);
-       ceph_osd_data_pagelist_init(osd_data, pagelist);
-}
-EXPORT_SYMBOL(osd_req_op_extent_osd_data_pagelist);
-
 #ifdef CONFIG_BLOCK
 void osd_req_op_extent_osd_data_bio(struct ceph_osd_request *osd_req,
                                    unsigned int which,
@@ -297,19 +287,6 @@ static void osd_req_op_cls_request_info_pagelist(
        ceph_osd_data_pagelist_init(osd_data, pagelist);
 }
 
-void osd_req_op_cls_request_data_pagelist(
-                       struct ceph_osd_request *osd_req,
-                       unsigned int which, struct ceph_pagelist *pagelist)
-{
-       struct ceph_osd_data *osd_data;
-
-       osd_data = osd_req_op_data(osd_req, which, cls, request_data);
-       ceph_osd_data_pagelist_init(osd_data, pagelist);
-       osd_req->r_ops[which].cls.indata_len += pagelist->length;
-       osd_req->r_ops[which].indata_len += pagelist->length;
-}
-EXPORT_SYMBOL(osd_req_op_cls_request_data_pagelist);
-
 void osd_req_op_cls_request_data_pages(struct ceph_osd_request *osd_req,
                        unsigned int which, struct page **pages, u64 length,
                        u32 alignment, bool pages_from_pool, bool own_pages)