smb1_srv: Use generate_random_str_list_buf()

Avoid a theoretical printf("%s", NULL)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/smbd/smb1_reply.c b/source3/smbd/smb1_reply.c
index 4256593897da9d407b515732a2c2edd27b62ce1f..fef3e95d2a28e63d98fd0250bf881d692d5c2c18 100644 (file)
--- a/source3/smbd/smb1_reply.c
+++ b/source3/smbd/smb1_reply.c
@@ -2573,15 +2573,19 @@ void reply_ctemp(struct smb_request *req)
        }
 
        for (i = 0; i < 10; i++) {
+               char rand_str[6];
+
+               generate_random_str_list_buf(rand_str,
+                                            sizeof(rand_str),
+                                            "0123456789");
+
                if (*wire_name) {
                        fname = talloc_asprintf(ctx,
-                                       "%s/TMP%s",
-                                       wire_name,
-                                       generate_random_str_list(ctx, 5, "0123456789"));
+                                               "%s/TMP%s",
+                                               wire_name,
+                                               rand_str);
                } else {
-                       fname = talloc_asprintf(ctx,
-                                       "TMP%s",
-                                       generate_random_str_list(ctx, 5, "0123456789"));
+                       fname = talloc_asprintf(ctx, "TMP%s", rand_str);
                }
 
                if (!fname) {