]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
dnsdist: Enable the DoQ and DoH3 parts of the SNI tests in our CI
authorRemi Gacogne <remi.gacogne@powerdns.com>
Wed, 2 Apr 2025 08:07:01 +0000 (10:07 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Wed, 2 Apr 2025 08:07:01 +0000 (10:07 +0200)
We now build with Quiche >= 0.23.2 so we can enable them.

regression-tests.dnsdist/runtests
regression-tests.dnsdist/test_SNI.py

index 40e65aaa7f269ea64e368388f3060e9bf8f5d0e2..b796beca376ac2aadbb21b97af4dfc7f91e927e0 100755 (executable)
@@ -2,6 +2,8 @@
 set -e
 
 export PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python
+# requires Quiche >= 0.23.2
+export ENABLE_SNI_TESTS_WITH_QUICHE=yes
 
 if [ ! -d .venv ]; then
   python3 -m venv .venv
index ac2f221040d90fae9a54cae66de483272bd90aa5..25611cb875508622a8c2b33e4f02218d6427527a 100644 (file)
@@ -39,7 +39,7 @@ class TestSNI(DNSDistTest):
     _config_params = ['_testServerPort', '_tlsServerPort', '_serverCert', '_serverKey', '_dohWithNGHTTP2ServerPort', '_serverCert', '_serverKey', '_doqServerPort', '_serverCert', '_serverKey', '_doh3ServerPort', '_serverCert', '_serverKey', '_serverName']
 
     # enable these once Quiche > 0.22 is available, including https://github.com/cloudflare/quiche/pull/1895
-    @unittest.skipUnless('ENABLE_SNI_TESTS_WITH_QUICHE' in os.environ, "SNI tests with Quicheare disabled")
+    @unittest.skipUnless('ENABLE_SNI_TESTS_WITH_QUICHE' in os.environ, "SNI tests with Quiche are disabled")
     def testServerNameIndicationWithQuiche(self):
         name = 'simple.sni.tests.powerdns.com.'
         query = dns.message.make_query(name, 'A', 'IN', use_edns=False)