]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net/tipc: replace deprecated strcpy with strscpy
authorHongbo Li <lihongbo22@huawei.com>
Wed, 28 Aug 2024 12:32:23 +0000 (20:32 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 29 Aug 2024 19:33:14 +0000 (12:33 -0700)
The deprecated helper strcpy() performs no bounds checking on the
destination buffer. This could result in linear overflows beyond
the end of the buffer, leading to all kinds of misbehaviors.
The safe replacement is strscpy() [1].

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
Link: https://patch.msgid.link/20240828123224.3697672-6-lihongbo22@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/tipc/bearer.c

index 3c9e25f6a1d222fbd50ca94e46ac877e7d6d9793..ae1ddbf71853924cb01c56bf75e40190f48dec45 100644 (file)
@@ -326,7 +326,7 @@ static int tipc_enable_bearer(struct net *net, const char *name,
        if (!b)
                return -ENOMEM;
 
-       strcpy(b->name, name);
+       strscpy(b->name, name);
        b->media = m;
        res = m->enable_media(net, b, attr);
        if (res) {