]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_tail_rpm()
authorMaxime Ripard <mripard@kernel.org>
Thu, 13 Feb 2025 14:43:28 +0000 (15:43 +0100)
committerMaxime Ripard <mripard@kernel.org>
Wed, 19 Feb 2025 15:59:15 +0000 (16:59 +0100)
drm_atomic_helper_commit_tail_rpm() is the final part of an atomic
commit, and is given the state being committed as a parameter.

However, that parameter is named old_state, but documented as the "new
modeset state" which is all super confusing.

Let's rename that parameter to state.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20250213-bridge-connector-v3-9-e71598f49c8f@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/drm_atomic_helper.c

index 70354f223daf52ffb7a651870c68d0835199418f..284dab6958c7e02a61a6442188382b649c41dc62 100644 (file)
@@ -1801,7 +1801,7 @@ EXPORT_SYMBOL(drm_atomic_helper_commit_tail);
 
 /**
  * drm_atomic_helper_commit_tail_rpm - commit atomic update to hardware
- * @old_state: new modeset state to be committed
+ * @state: new modeset state to be committed
  *
  * This is an alternative implementation for the
  * &drm_mode_config_helper_funcs.atomic_commit_tail hook, for drivers
@@ -1809,24 +1809,24 @@ EXPORT_SYMBOL(drm_atomic_helper_commit_tail);
  * commit. Otherwise, one should use the default implementation
  * drm_atomic_helper_commit_tail().
  */
-void drm_atomic_helper_commit_tail_rpm(struct drm_atomic_state *old_state)
+void drm_atomic_helper_commit_tail_rpm(struct drm_atomic_state *state)
 {
-       struct drm_device *dev = old_state->dev;
+       struct drm_device *dev = state->dev;
 
-       drm_atomic_helper_commit_modeset_disables(dev, old_state);
+       drm_atomic_helper_commit_modeset_disables(dev, state);
 
-       drm_atomic_helper_commit_modeset_enables(dev, old_state);
+       drm_atomic_helper_commit_modeset_enables(dev, state);
 
-       drm_atomic_helper_commit_planes(dev, old_state,
+       drm_atomic_helper_commit_planes(dev, state,
                                        DRM_PLANE_COMMIT_ACTIVE_ONLY);
 
-       drm_atomic_helper_fake_vblank(old_state);
+       drm_atomic_helper_fake_vblank(state);
 
-       drm_atomic_helper_commit_hw_done(old_state);
+       drm_atomic_helper_commit_hw_done(state);
 
-       drm_atomic_helper_wait_for_vblanks(dev, old_state);
+       drm_atomic_helper_wait_for_vblanks(dev, state);
 
-       drm_atomic_helper_cleanup_planes(dev, old_state);
+       drm_atomic_helper_cleanup_planes(dev, state);
 }
 EXPORT_SYMBOL(drm_atomic_helper_commit_tail_rpm);