]> git.ipfire.org Git - thirdparty/dracut.git/commitdiff
fix(nvdimm): shellcheck regression
authorHarald Hoyer <harald@redhat.com>
Wed, 31 Mar 2021 08:59:19 +0000 (10:59 +0200)
committerHarald Hoyer <harald@hoyer.xyz>
Wed, 31 Mar 2021 09:29:07 +0000 (11:29 +0200)
`_provider_dirs` should not have been quoted, because it should expand
to multiple arguments.

Just remove the whole variable and add those arguments.

Fixes: https://github.com/dracutdevs/dracut/issues/1273
modules.d/90nvdimm/module-setup.sh

index d123cb45b22504bbbf19fc5c9b184578a2c31d57..8d336108193e3f226aefbf1c9ed8eb71523f32b5 100755 (executable)
@@ -19,10 +19,11 @@ depends() {
 installkernel() {
     # Directories to search for NVDIMM "providers" (firmware drivers)
     # These modules call "nvdimm_bus_register()".
-    local _provider_dirs='=drivers/nvdimm =drivers/acpi =arch/powerpc'
-
     #instmods() will take care of hostonly
-    dracut_instmods -o -s nvdimm_bus_register "$_provider_dirs"
+    dracut_instmods -o -s nvdimm_bus_register \
+        '=drivers/nvdimm' \
+        '=drivers/acpi' \
+        '=arch/powerpc'
 }
 
 # called by dracut