smb: server: smb2pdu: check return value of xa_store()

xa_store() may fail so check its return value and return error code if
error occurred.

Signed-off-by: Salah Triki <salah.triki@gmail.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index 57839f9708bb6c973e48219921ffaa59414d7624..372021b3f2632cd30aea3500c6de6553c66047de 100644 (file)
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -1445,7 +1445,7 @@ static int ntlm_authenticate(struct ksmbd_work *work,
 {
        struct ksmbd_conn *conn = work->conn;
        struct ksmbd_session *sess = work->sess;
-       struct channel *chann = NULL;
+       struct channel *chann = NULL, *old;
        struct ksmbd_user *user;
        u64 prev_id;
        int sz, rc;
@@ -1557,7 +1557,12 @@ binding_session:
                                return -ENOMEM;
 
                        chann->conn = conn;
-                       xa_store(&sess->ksmbd_chann_list, (long)conn, chann, KSMBD_DEFAULT_GFP);
+                       old = xa_store(&sess->ksmbd_chann_list, (long)conn, chann,
+                                       KSMBD_DEFAULT_GFP);
+                       if (xa_is_err(old)) {
+                               kfree(chann);
+                               return xa_err(old);
+                       }
                }
        }