]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pmdomain: ti-sci: Add missing of_node_put() for args.np
authorZhang Zekun <zhangzekun11@huawei.com>
Thu, 24 Oct 2024 03:04:41 +0000 (11:04 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 31 Oct 2024 10:30:57 +0000 (11:30 +0100)
of_parse_phandle_with_args() needs to call of_node_put() to decrement
the refcount of args.np. So, Add the missing of_node_put() in the loop.

Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds instead of one")
Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Message-ID: <20241024030442.119506-2-zhangzekun11@huawei.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/pmdomain/ti/ti_sci_pm_domains.c

index 38448b4a035a93f123a9c8fea213bb9182be7f90..f145f0225524f0e0e3e6d7808143bab8c30518c3 100644 (file)
@@ -161,6 +161,7 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev)
                                break;
 
                        if (args.args_count >= 1 && args.np == dev->of_node) {
+                               of_node_put(args.np);
                                if (args.args[0] > max_id) {
                                        max_id = args.args[0];
                                } else {
@@ -193,7 +194,10 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev)
                                pm_genpd_init(&pd->pd, NULL, true);
 
                                list_add(&pd->node, &pd_provider->pd_list);
+                       } else {
+                               of_node_put(args.np);
                        }
+
                        index++;
                }
        }