If RelationBuildDesc() fails to open a critical system index, PANIC with

a relevant error message instead of just dumping core.  Odd that nobody
reported this before Darren Reed.

diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index 7cd093d2faf8ef2cc3995fb89e662dd41301cd7b..d1d3d8a901a9cf7f290c98b4390fe2ecbeba0527 100644 (file)
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.215.4.1 2006/01/19 20:28:57 tgl Exp $
+ *       $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.215.4.2 2008/02/27 17:44:51 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -2404,6 +2404,9 @@ RelationCacheInitializePhase2(void)
                        buildinfo.infotype = INFO_RELNAME; \
                        buildinfo.i.info_name = (indname); \
                        ird = RelationBuildDesc(buildinfo, NULL); \
+                       if (ird == NULL) \
+                               elog(PANIC, "could not open critical system index \"%s\"", \
+                                        indname); \
                        ird->rd_isnailed = true; \
                        ird->rd_refcnt = 1; \
                } while (0)