]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
doveadm: doveadm-mail-mailbox-metadata - Handle error in doveadm_print_istream
authorAki Tuomi <aki.tuomi@open-xchange.com>
Thu, 23 Jan 2020 08:42:20 +0000 (10:42 +0200)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Wed, 5 Feb 2020 12:10:32 +0000 (12:10 +0000)
Found by coverity

src/doveadm/doveadm-mail-mailbox-metadata.c

index 2fad6e97def2250731d991aded4645dd92f443c8..c1715ec1be9b60777f9913de402d6813c87a6658 100644 (file)
@@ -2,6 +2,7 @@
 
 #include "lib.h"
 #include "str.h"
+#include "istream.h"
 #include "mail-namespace.h"
 #include "mail-storage.h"
 #include "doveadm-print.h"
@@ -219,7 +220,12 @@ cmd_mailbox_metadata_get_run(struct doveadm_mail_cmd_context *_ctx,
                /* not found, print as empty */
                doveadm_print("");
        } else if (value.value_stream != NULL) {
-               doveadm_print_istream(value.value_stream);
+               if (doveadm_print_istream(value.value_stream) < 0) {
+                       i_error("read(%s) failed: %s",
+                               i_stream_get_name(value.value_stream),
+                               i_stream_get_error(value.value_stream));
+                       ret = -1;
+               }
        } else {
                doveadm_print(value.value);
        }