]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
bpftool: Fix handling enum64 in btf dump sorting
authorMykyta Yatsenko <yatsenko@meta.com>
Mon, 2 Sep 2024 17:17:21 +0000 (18:17 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 2 Sep 2024 20:44:51 +0000 (22:44 +0200)
Wrong function is used to access the first enum64 element. Substituting btf_enum(t)
with btf_enum64(t) for BTF_KIND_ENUM64.

Fixes: 94133cf24bb3 ("bpftool: Introduce btf c dump sorting")
Signed-off-by: Mykyta Yatsenko <yatsenko@meta.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Quentin Monnet <qmo@kernel.org>
Link: https://lore.kernel.org/bpf/20240902171721.105253-1-mykyta.yatsenko5@gmail.com
tools/bpf/bpftool/btf.c

index 6789c7a4d5ca1de84e6397d302b1d59500f132a6..3b57ba095ab61de99ab32e64f6b63086c8e1c4b8 100644 (file)
@@ -561,9 +561,10 @@ static const char *btf_type_sort_name(const struct btf *btf, __u32 index, bool f
        case BTF_KIND_ENUM64: {
                int name_off = t->name_off;
 
-               /* Use name of the first element for anonymous enums if allowed */
-               if (!from_ref && !t->name_off && btf_vlen(t))
-                       name_off = btf_enum(t)->name_off;
+               if (!from_ref && !name_off && btf_vlen(t))
+                       name_off = btf_kind(t) == BTF_KIND_ENUM64 ?
+                               btf_enum64(t)->name_off :
+                               btf_enum(t)->name_off;
 
                return btf__name_by_offset(btf, name_off);
        }