]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
perf/core: Fix event timekeeping merge
authorPeter Zijlstra <peterz@infradead.org>
Wed, 16 Apr 2025 09:36:24 +0000 (11:36 +0200)
committerIngo Molnar <mingo@kernel.org>
Thu, 17 Apr 2025 12:21:15 +0000 (14:21 +0200)
Due to an oversight in merging:

  da916e96e2de ("perf: Make perf_pmu_unregister() useable")

on top of:

  a3c3c66670ce ("perf/core: Fix child_total_time_enabled accounting bug at task exit")

the timekeeping fix from this latter patch got undone.

Redo it.

Fixes: da916e96e2de ("perf: Make perf_pmu_unregister() useable")
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lkml.kernel.org/r/20250417080815.GI38216@noisy.programming.kicks-ass.net
kernel/events/core.c

index 43d87de3d4f247b82bde568a15478cdced7cf4b0..07414cb1279bdd5d5ead9acc8829e9ee7d53bca5 100644 (file)
@@ -2500,14 +2500,14 @@ __perf_remove_from_context(struct perf_event *event,
                state = PERF_EVENT_STATE_DEAD;
        }
        event_sched_out(event, ctx);
+       perf_event_set_state(event, min(event->state, state));
+
        if (flags & DETACH_GROUP)
                perf_group_detach(event);
        if (flags & DETACH_CHILD)
                perf_child_detach(event);
        list_del_event(event, ctx);
 
-       event->state = min(event->state, state);
-
        if (!pmu_ctx->nr_events) {
                pmu_ctx->rotate_necessary = 0;