]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
regulator: Use of_property_read_bool()
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 19:13:02 +0000 (13:13 -0600)
committerMark Brown <broonie@kernel.org>
Thu, 1 Aug 2024 11:50:11 +0000 (12:50 +0100)
Use of_property_read_bool() to read boolean properties rather than
of_get_property(). This is part of a larger effort to remove callers
of of_get_property() and similar functions. of_get_property() leaks
the DT property data pointer which is a problem for dynamically
allocated nodes which may be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20240731191312.1710417-24-robh@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/act8865-regulator.c
drivers/regulator/max8997-regulator.c

index a504b01dd99c8ffe1735bcf8087c54e85cfd7d03..0457af23c55acdd97b2cdc6fd6bfd07ae0f9d11f 100644 (file)
@@ -673,9 +673,7 @@ static int act8865_pmic_probe(struct i2c_client *client)
 
                type = (unsigned long) id->data;
 
-               voltage_select = !!of_get_property(dev->of_node,
-                                                  "active-semi,vsel-high",
-                                                  NULL);
+               voltage_select = of_property_read_bool(dev->of_node, "active-semi,vsel-high");
        } else {
                type = i2c_id->driver_data;
                pdata = dev_get_platdata(dev);
index 5f201ee9a5b8033658424ad6f64e57072d795232..cdbfb4561dd8803b62bb8e14438205337700bdf6 100644 (file)
@@ -941,9 +941,8 @@ static int max8997_pmic_dt_parse_pdata(struct platform_device *pdev,
                        }
                }
 
-               if (of_get_property(pmic_np,
-                       "max8997,pmic-ignore-gpiodvs-side-effect", NULL))
-                       pdata->ignore_gpiodvs_side_effect = true;
+               pdata->ignore_gpiodvs_side_effect = of_property_read_bool(pmic_np,
+                       "max8997,pmic-ignore-gpiodvs-side-effect");
 
                dvs_voltage_nr = 8;
        }