]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ALSA: usb-audio: US16x08: Initialize array before use
authorTanya Agarwal <tanyaagarwal25699@gmail.com>
Sun, 29 Dec 2024 06:02:42 +0000 (11:32 +0530)
committerTakashi Iwai <tiwai@suse.de>
Sun, 29 Dec 2024 08:27:21 +0000 (09:27 +0100)
Initialize meter_urb array before use in mixer_us16x08.c.

CID 1410197: (#1 of 1): Uninitialized scalar variable (UNINIT)
uninit_use_in_call: Using uninitialized value *meter_urb when
calling get_meter_levels_from_urb.

Coverity Link:
https://scan7.scan.coverity.com/#/project-view/52849/11354?selectedIssue=1410197

Fixes: d2bb390a2081 ("ALSA: usb-audio: Tascam US-16x08 DSP mixer quirk")
Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
Link: https://patch.msgid.link/20241229060240.1642-1-tanyaagarwal25699@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer_us16x08.c

index 6eb7d93b358d99cdd4d5b6c2d8e587ba725eae10..20ac32635f1f50865b0fd5a226a753fe56483ff3 100644 (file)
@@ -687,7 +687,7 @@ static int snd_us16x08_meter_get(struct snd_kcontrol *kcontrol,
        struct usb_mixer_elem_info *elem = kcontrol->private_data;
        struct snd_usb_audio *chip = elem->head.mixer->chip;
        struct snd_us16x08_meter_store *store = elem->private_data;
-       u8 meter_urb[64];
+       u8 meter_urb[64] = {0};
 
        switch (kcontrol->private_value) {
        case 0: {