selftests/bpf: Socket pair creation, cleanups

Following create_pair() changes, remove unused function argument in
create_socket_pairs() and adapt its callers, i.e. drop the open-coded
loopback socket creation.

Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
Tested-by: Jakub Sitnicki <jakub@cloudflare.com>
Suggested-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Michal Luczaj <mhal@rbox.co>
Link: https://lore.kernel.org/r/20240731-selftest-sockmap-fixes-v2-2-08a0c73abed2@rbox.co
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>

diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
index 5b17d69c9ee68c49f885905886a39eeacdbbc597..82bfb266741cfaceafa2a407cd2ccc937708c613 100644 (file)
--- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
+++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
@@ -503,8 +503,8 @@ out:
 
 static void test_sockmap_skb_verdict_fionread(bool pass_prog)
 {
+       int err, map, verdict, c0 = -1, c1 = -1, p0 = -1, p1 = -1;
        int expected, zero = 0, sent, recvd, avail;
-       int err, map, verdict, s, c0 = -1, c1 = -1, p0 = -1, p1 = -1;
        struct test_sockmap_pass_prog *pass = NULL;
        struct test_sockmap_drop_prog *drop = NULL;
        char buf[256] = "0123456789";
@@ -531,11 +531,8 @@ static void test_sockmap_skb_verdict_fionread(bool pass_prog)
        if (!ASSERT_OK(err, "bpf_prog_attach"))
                goto out;
 
-       s = socket_loopback(AF_INET, SOCK_STREAM);
-       if (!ASSERT_GT(s, -1, "socket_loopback(s)"))
-               goto out;
-       err = create_socket_pairs(s, AF_INET, SOCK_STREAM, &c0, &c1, &p0, &p1);
-       if (!ASSERT_OK(err, "create_socket_pairs(s)"))
+       err = create_socket_pairs(AF_INET, SOCK_STREAM, &c0, &c1, &p0, &p1);
+       if (!ASSERT_OK(err, "create_socket_pairs()"))
                goto out;
 
        err = bpf_map_update_elem(map, &zero, &c1, BPF_NOEXIST);

diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_helpers.h b/tools/testing/selftests/bpf/prog_tests/sockmap_helpers.h
index 77b73333f091aa0d049a80ad751ce1e091745678..ead8ea4fd0da24082ffd26a37e39da2bca1f8bcd 100644 (file)
--- a/tools/testing/selftests/bpf/prog_tests/sockmap_helpers.h
+++ b/tools/testing/selftests/bpf/prog_tests/sockmap_helpers.h
@@ -437,8 +437,8 @@ close_s:
        return err;
 }
 
-static inline int create_socket_pairs(int s, int family, int sotype,
-                                     int *c0, int *c1, int *p0, int *p1)
+static inline int create_socket_pairs(int family, int sotype, int *c0, int *c1,
+                                     int *p0, int *p1)
 {
        int err;
 

diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_listen.c b/tools/testing/selftests/bpf/prog_tests/sockmap_listen.c
index 9ce0e0e0b7da75f257491454986a8c3136fc13ed..bfbc217637d192409e3c8c0c1b3259ea22c76feb 100644 (file)
--- a/tools/testing/selftests/bpf/prog_tests/sockmap_listen.c
+++ b/tools/testing/selftests/bpf/prog_tests/sockmap_listen.c
@@ -677,7 +677,7 @@ static void redir_to_connected(int family, int sotype, int sock_mapfd,
                               int verd_mapfd, enum redir_mode mode)
 {
        const char *log_prefix = redir_mode_str(mode);
-       int s, c0, c1, p0, p1;
+       int c0, c1, p0, p1;
        unsigned int pass;
        int err, n;
        u32 key;
@@ -685,13 +685,10 @@ static void redir_to_connected(int family, int sotype, int sock_mapfd,
 
        zero_verdict_count(verd_mapfd);
 
-       s = socket_loopback(family, sotype | SOCK_NONBLOCK);
-       if (s < 0)
-               return;
-
-       err = create_socket_pairs(s, family, sotype, &c0, &c1, &p0, &p1);
+       err = create_socket_pairs(family, sotype | SOCK_NONBLOCK, &c0, &c1,
+                                 &p0, &p1);
        if (err)
-               goto close_srv;
+               return;
 
        err = add_to_sockmap(sock_mapfd, p0, p1);
        if (err)
@@ -722,8 +719,6 @@ close:
        xclose(c1);
        xclose(p0);
        xclose(c0);
-close_srv:
-       xclose(s);
 }
 
 static void test_skb_redir_to_connected(struct test_sockmap_listen *skel,
@@ -909,7 +904,7 @@ static void test_msg_redir_to_listening_with_link(struct test_sockmap_listen *sk
 
 static void redir_partial(int family, int sotype, int sock_map, int parser_map)
 {
-       int s, c0 = -1, c1 = -1, p0 = -1, p1 = -1;
+       int c0 = -1, c1 = -1, p0 = -1, p1 = -1;
        int err, n, key, value;
        char buf[] = "abc";
 
@@ -919,13 +914,10 @@ static void redir_partial(int family, int sotype, int sock_map, int parser_map)
        if (err)
                return;
 
-       s = socket_loopback(family, sotype | SOCK_NONBLOCK);
-       if (s < 0)
-               goto clean_parser_map;
-
-       err = create_socket_pairs(s, family, sotype, &c0, &c1, &p0, &p1);
+       err = create_socket_pairs(family, sotype | SOCK_NONBLOCK, &c0, &c1,
+                                 &p0, &p1);
        if (err)
-               goto close_srv;
+               goto clean_parser_map;
 
        err = add_to_sockmap(sock_map, p0, p1);
        if (err)
@@ -944,8 +936,6 @@ close:
        xclose(p0);
        xclose(c1);
        xclose(p1);
-close_srv:
-       xclose(s);
 
 clean_parser_map:
        key = 0;