feat: proper check of computed requiring @vue/composition-api@1.2.3

diff --git a/packages/pinia/package.json b/packages/pinia/package.json
index 67269df6d9a3704058459886d2a917d700cba7ec..e9f9dfbb36cb7c8c5851b1aac3d50b1cdd3c4cf3 100644 (file)
--- a/packages/pinia/package.json
+++ b/packages/pinia/package.json
@@ -73,7 +73,7 @@
     "vue-demi": "*"
   },
   "peerDependencies": {
-    "@vue/composition-api": "^1.2.2",
+    "@vue/composition-api": "^1.2.3",
     "typescript": "^4.4.3",
     "vue": "^2.6.14 || ^3.2.0"
   },

diff --git a/packages/pinia/src/store.ts b/packages/pinia/src/store.ts
index 96b8465f07333bc6c69708d442c671ffcc827fa4..ca0b69d4b90480b90b5726ddc8613e81af69a9b2 100644 (file)
--- a/packages/pinia/src/store.ts
+++ b/packages/pinia/src/store.ts
@@ -77,15 +77,7 @@ const { assign } = Object
 
 function isComputed<T>(value: ComputedRef<T> | unknown): value is ComputedRef<T>
 function isComputed(o: any): o is ComputedRef {
-  if (isVue2) {
-    const descriptor = o ? Object.getOwnPropertyDescriptor(o, 'value') : null
-    return (descriptor &&
-      descriptor.get &&
-      // TODO: make something in @vue/composition-api to be able to check this
-      descriptor.get.toString().length > 42) as boolean
-  }
-  // !!(isRef(o) && o.effect)
-  return o && o.effect
+  return !!(isRef(o) && (o as any).effect)
 }
 
 function createOptionsStore<