]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
eth: fbnic: Reset hw stats upon PCI error
authorMohsin Bashir <mohsin.bashr@gmail.com>
Mon, 25 Aug 2025 20:02:02 +0000 (13:02 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 28 Aug 2025 01:56:19 +0000 (18:56 -0700)
Upon experiencing a PCI error, fbnic reset the device to recover from
the failure. Reset the hardware stats as part of the device reset to
ensure accurate stats reporting.

Note that the reset is not really resetting the aggregate value to 0,
which may result in a spike for a system collecting deltas in stats.
Rather, the reset re-latches the current value as previous, in case HW
got reset.

Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250825200206.2357713-3-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/meta/fbnic/fbnic_pci.c

index 8190f49e14266fa4265e69d57d78f1c88a0bfdd3..953297f667a25137d651680cfc17249b01cac19c 100644 (file)
@@ -491,6 +491,8 @@ static void __fbnic_pm_attach(struct device *dev)
        struct net_device *netdev = fbd->netdev;
        struct fbnic_net *fbn;
 
+       fbnic_reset_hw_stats(fbd);
+
        if (fbnic_init_failure(fbd))
                return;