]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
Removed assert call as suggested in merge request.
authorKarel Slany <karel.slany@nic.cz>
Tue, 26 Jul 2016 08:49:21 +0000 (10:49 +0200)
committerOndřej Surý <ondrej@sury.org>
Thu, 11 Aug 2016 12:06:45 +0000 (14:06 +0200)
modules/cookies/cookiemonster.c

index 30e3b0639714d9410537c56d4ff458144d5c7173..c49dabfcba8f5729023d2687889c5c4e984b0db8 100644 (file)
@@ -239,9 +239,9 @@ static bool check_cookie_content_and_cache(const struct kr_cookie_settings *clnt
 {
        assert(clnt_sett && req && pkt_cookie_opt && cache);
 
-       uint8_t *pkt_cookie_data = knot_edns_opt_get_data(pkt_cookie_opt);
+       const uint8_t *pkt_cookie_data = knot_edns_opt_get_data(pkt_cookie_opt);
        uint16_t pkt_cookie_len = knot_edns_opt_get_length(pkt_cookie_opt);
-       assert(pkt_cookie_data && pkt_cookie_len);
+       /* knot_edns_opt_cookie_parse() returns error on invalid data. */
 
        const uint8_t *pkt_cc = NULL, *pkt_sc = NULL;
        uint16_t pkt_cc_len = 0, pkt_sc_len = 0;