Fix thinko in objcopy's memory freeing code.

	* objcopy.c (copy_main): Fix a double free happening when both
	--localize-symbols and --globalize-symbols options are invoked
	together.

(cherry picked from commit e37709f0901fe6f2410094151002bab3d123df85)

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 4b6cd9f755e8a4de3ad49af8c1045aca2686fc55..b701b69ecb0e9eda0953fe744f5864748a8af1e3 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,9 @@
+2021-01-26  Frederic Cambus  <fred@statdns.com>
+
+       * objcopy.c (copy_main): Fix a double free happening when both
+       --localize-symbols and --globalize-symbols options are invoked
+       together.
+
 2021-01-01  Alan Modra  <amodra@gmail.com>
 
        Apply from master

diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index 3866c7f458861dd522a44e07b20d8485f66719b1..b730b25ff564a5cc1236fa2367810a6a9c5e73a4 100644 (file)
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -5953,7 +5953,7 @@ copy_main (int argc, char *argv[])
     free (keep_specific_buffer);
 
   if (localize_specific_buffer)
-    free (globalize_specific_buffer);
+    free (localize_specific_buffer);
 
   if (globalize_specific_buffer)
     free (globalize_specific_buffer);