]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hwmon: lm70: simplify with spi_get_device_match_data()
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 6 Jun 2024 14:25:15 +0000 (16:25 +0200)
committerGuenter Roeck <linux@roeck-us.net>
Sat, 8 Jun 2024 23:07:32 +0000 (16:07 -0700)
Use spi_get_device_match_data() helper to simplify a bit the driver.
Also kernel_ulong_t type is preferred for kernel code over uintptr_t
(needed for the cast).

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240606142515.132504-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/lm70.c

index 481e4e1f8f4f68c677ea055b83a8ff9e4dcf1cc8..0d5a250cb6722ab62734c2d175780ff4c26e1429 100644 (file)
@@ -169,11 +169,7 @@ static int lm70_probe(struct spi_device *spi)
        struct lm70 *p_lm70;
        int chip;
 
-       if (dev_fwnode(&spi->dev))
-               chip = (int)(uintptr_t)device_get_match_data(&spi->dev);
-       else
-               chip = spi_get_device_id(spi)->driver_data;
-
+       chip = (kernel_ulong_t)spi_get_device_match_data(spi);
 
        /* signaling is SPI_MODE_0 */
        if ((spi->mode & SPI_MODE_X_MASK) != SPI_MODE_0)