]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
vl: allow not specifying size in -m when using -M memory-backend
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 17 May 2021 14:13:01 +0000 (10:13 -0400)
committerMichael Roth <michael.roth@amd.com>
Thu, 14 Oct 2021 20:10:19 +0000 (15:10 -0500)
Starting in QEMU 6.0's commit f5c9fcb82d ("vl: separate
qemu_create_machine", 2020-12-10), a function have_custom_ram_size()
replaced the return value of set_memory_options().

The purpose of the return value was to record the presence of
"-m size", and if it was not there, change the default RAM
size to the size of the memory backend passed with "-M
memory-backend".

With that commit, however, have_custom_ram_size() is now queried only
after set_memory_options has stored the fixed-up RAM size in QemuOpts for
"future use".  This was actually the only future use of the fixed-up RAM
size, so remove that code and fix the bug.

Cc: qemu-stable@nongnu.org
Fixes: f5c9fcb82d ("vl: separate qemu_create_machine", 2020-12-10)
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit d349f92f78d26db2805ca39a7745cc70affea021)
Signed-off-by: Michael Roth <michael.roth@amd.com>
softmmu/vl.c

index aadb52613888ef6ac1fe7ec3a0382e8b4cb50ef6..29d6415d5ccc2159052b2a7b271ef6a8c70310d7 100644 (file)
@@ -2025,8 +2025,6 @@ static void set_memory_options(MachineClass *mc)
         exit(EXIT_FAILURE);
     }
 
-    /* store value for the future use */
-    qemu_opt_set_number(opts, "size", ram_size, &error_abort);
     maxram_size = ram_size;
 
     if (qemu_opt_get(opts, "maxmem")) {