]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
btrfs: remove unnecessary NULL checks before freeing extent state
authorFilipe Manana <fdmanana@suse.com>
Wed, 23 Apr 2025 09:41:31 +0000 (10:41 +0100)
committerDavid Sterba <dsterba@suse.com>
Thu, 15 May 2025 12:30:52 +0000 (14:30 +0200)
When manipulating extent bits for an io tree range, we have this pattern:

   if (prealloc)
          btrfs_free_extent_state(prealloc);

but this is not needed nowadays since btrfs_free_extent_state() ignores
a NULL pointer argument, following the common pattern of kernel and btrfs
freeing functions, as well as libc and other user space libraries.
So remove the NULL checks, reducing source code and object size.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent-io-tree.c

index dd36322fbf6b588c76dbd72b9dd70077adf44ba0..9266bb39c619c340707fcd81b0af608582734698 100644 (file)
@@ -761,8 +761,7 @@ search_again:
 
 out:
        spin_unlock(&tree->lock);
-       if (prealloc)
-               btrfs_free_extent_state(prealloc);
+       btrfs_free_extent_state(prealloc);
 
        return ret;
 
@@ -1285,8 +1284,7 @@ search_again:
 
 out:
        spin_unlock(&tree->lock);
-       if (prealloc)
-               btrfs_free_extent_state(prealloc);
+       btrfs_free_extent_state(prealloc);
 
        return ret;
 
@@ -1525,8 +1523,7 @@ search_again:
 
 out:
        spin_unlock(&tree->lock);
-       if (prealloc)
-               btrfs_free_extent_state(prealloc);
+       btrfs_free_extent_state(prealloc);
 
        return ret;
 }