]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
RDMA/uverbs: Update outdated reference to remove_commit_idr_uobject()
authorKexin Sun <kexinsun@smail.nju.edu.cn>
Sat, 21 Mar 2026 10:58:59 +0000 (18:58 +0800)
committerLeon Romanovsky <leon@kernel.org>
Mon, 30 Mar 2026 17:47:44 +0000 (13:47 -0400)
The function remove_commit_idr_uobject() was split into
destroy_hw_idr_uobject() and remove_handle_idr_uobject() by
commit 0f50d88a6e9a ("IB/uverbs: Allow all DESTROY commands
to succeed after disassociate").  The kref put that the
comment refers to now lives in remove_handle_idr_uobject().
Update the stale reference.

Also update "allocated this IDR with a NULL object" to
"allocated this XArray entry with a NULL pointer" to match
the actual data structure (xa_store) and the wording already
used two lines below ("transfers our kref on uobj to the
XArray").

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
Link: https://patch.msgid.link/20260321105859.7642-1-kexinsun@smail.nju.edu.cn
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/core/rdma_core.c

index 3e0a8b9cd288a08424139c3a62e350da6302fe82..5018ec837056ff1a943d20327a63a8cfeb6a7136 100644 (file)
@@ -590,11 +590,11 @@ static void alloc_commit_idr_uobject(struct ib_uobject *uobj)
        void *old;
 
        /*
-        * We already allocated this IDR with a NULL object, so
+        * We already allocated this XArray entry with a NULL pointer, so
         * this shouldn't fail.
         *
         * NOTE: Storing the uobj transfers our kref on uobj to the XArray.
-        * It will be put by remove_commit_idr_uobject()
+        * It will be put by remove_handle_idr_uobject()
         */
        old = xa_store(&ufile->idr, uobj->id, uobj, GFP_KERNEL);
        WARN_ON(old != NULL);