librpc/py_security: Don’t pass a NULL pointer to PyUnicode_FromString()

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/librpc/ndr/py_security.c b/source4/librpc/ndr/py_security.c
index 217b7dc19d1403a7fc839730cf455030884aa805..74c73dd8dfed6639fd3925d04b4fece94dcfbd9c 100644 (file)
--- a/source4/librpc/ndr/py_security.c
+++ b/source4/librpc/ndr/py_security.c
@@ -310,6 +310,10 @@ static PyObject *py_descriptor_as_sddl(PyObject *self, PyObject *args)
                sid = NULL;
 
        text = sddl_encode(NULL, desc, sid);
+       if (text == NULL) {
+               PyErr_SetString(PyExc_ValueError, "Unable to encode SDDL");
+               return NULL;
+       }
 
        ret = PyUnicode_FromString(text);