]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: openvswitch: Use ERR_CAST() to return
authorYan Zhen <yanzhen@vivo.com>
Thu, 29 Aug 2024 09:55:09 +0000 (17:55 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 30 Aug 2024 18:11:45 +0000 (11:11 -0700)
Using ERR_CAST() is more reasonable and safer, When it is necessary
to convert the type of an error pointer and return it.

Signed-off-by: Yan Zhen <yanzhen@vivo.com>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Reviewed-by: Aaron Conole <aconole@redhat.com>
Link: https://patch.msgid.link/20240829095509.3151987-1-yanzhen@vivo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/openvswitch/flow_netlink.c

index c92bdc4dfe196027e2cdf699ff7ad4abad1adf1d..729ef582a3a8b85e00a09c300570d74a7b28b693 100644 (file)
@@ -2491,7 +2491,7 @@ static struct nlattr *reserve_sfa_size(struct sw_flow_actions **sfa,
 
        acts = nla_alloc_flow_actions(new_acts_size);
        if (IS_ERR(acts))
-               return (void *)acts;
+               return ERR_CAST(acts);
 
        memcpy(acts->actions, (*sfa)->actions, (*sfa)->actions_len);
        acts->actions_len = (*sfa)->actions_len;