]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 1 Aug 2025 13:34:37 +0000 (16:34 +0300)
committerManivannan Sadhasivam <mani@kernel.org>
Mon, 11 Aug 2025 11:00:43 +0000 (16:30 +0530)
There is a typo so we accidentally return positive EINVAL instead of
negative -EINVAL. Add the missing '-' character.

Fixes: 6aceb36f17ab ("PCI: xgene-msi: Restructure handler setup/teardown")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Acked-by: Marc Zyngier <maz@kernel.org>
Link: https://patch.msgid.link/aIzCbVd93ivPinne@stanley.mountain
drivers/pci/controller/pci-xgene-msi.c

index 0a37a3f1809c50992210156db97411af408ed004..654639bccd10e35758ac3858b1cd40657f7335ec 100644 (file)
@@ -311,7 +311,7 @@ static int xgene_msi_handler_setup(struct platform_device *pdev)
                msi_val = xgene_msi_int_read(xgene_msi, i);
                if (msi_val) {
                        dev_err(&pdev->dev, "Failed to clear spurious IRQ\n");
-                       return EINVAL;
+                       return -EINVAL;
                }
 
                irq = platform_get_irq(pdev, i);