]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mtd: spinand: Improve spinand_info macros style
authorMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 4 Mar 2025 11:05:39 +0000 (12:05 +0100)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 18 Mar 2025 15:56:02 +0000 (16:56 +0100)
Let's assume all these macros should not have a trailing comma, this way
the caller can use a more formal and usual C writing style, as reflected
in the Macronix driver.

Acked-by: Pratyush Yadav <pratyush@kernel.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/spi/macronix.c
include/linux/mtd/spinand.h

index c9abac46ed0539b69ef5990dff83e9a7453861f6..1ef08ad850a2fe04bea3560bbf859b572089335a 100644 (file)
@@ -187,7 +187,7 @@ static const struct spinand_info macronix_spinand_table[] = {
                     SPINAND_HAS_QE_BIT,
                     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
                                     macronix_ecc_get_status),
-                    SPINAND_CONT_READ(macronix_set_cont_read)
+                    SPINAND_CONT_READ(macronix_set_cont_read),
                     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
                                        macronix_set_read_retry)),
        SPINAND_INFO("MX35LF4GE4AD",
@@ -200,7 +200,7 @@ static const struct spinand_info macronix_spinand_table[] = {
                     SPINAND_HAS_QE_BIT,
                     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
                                     macronix_ecc_get_status),
-                    SPINAND_CONT_READ(macronix_set_cont_read)
+                    SPINAND_CONT_READ(macronix_set_cont_read),
                     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
                                        macronix_set_read_retry)),
        SPINAND_INFO("MX35LF1G24AD",
@@ -328,7 +328,7 @@ static const struct spinand_info macronix_spinand_table[] = {
                     SPINAND_HAS_QE_BIT,
                     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
                                     macronix_ecc_get_status),
-                    SPINAND_CONT_READ(macronix_set_cont_read)
+                    SPINAND_CONT_READ(macronix_set_cont_read),
                     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
                                        macronix_set_read_retry)),
        SPINAND_INFO("MX35UF2G14AC",
@@ -378,7 +378,7 @@ static const struct spinand_info macronix_spinand_table[] = {
                     SPINAND_HAS_QE_BIT,
                     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
                                     macronix_ecc_get_status),
-                    SPINAND_CONT_READ(macronix_set_cont_read)
+                    SPINAND_CONT_READ(macronix_set_cont_read),
                     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
                                        macronix_set_read_retry)),
        SPINAND_INFO("MX35UF2GE4AC",
@@ -424,7 +424,7 @@ static const struct spinand_info macronix_spinand_table[] = {
                     SPINAND_HAS_QE_BIT,
                     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
                                     macronix_ecc_get_status),
-                    SPINAND_CONT_READ(macronix_set_cont_read)
+                    SPINAND_CONT_READ(macronix_set_cont_read),
                     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
                                        macronix_set_read_retry)),
        SPINAND_INFO("MX35UF1GE4AC",
index 5837a09ab9d8350f83e7899a2302336ee573fa8a..1e748958dad404e4c064081f9c96aaecfef9ee53 100644 (file)
@@ -502,10 +502,10 @@ struct spinand_info {
        }
 
 #define SPINAND_SELECT_TARGET(__func)                                  \
-       .select_target = __func,
+       .select_target = __func
 
 #define SPINAND_CONT_READ(__set_cont_read)                             \
-       .set_cont_read = __set_cont_read,
+       .set_cont_read = __set_cont_read
 
 #define SPINAND_FACT_OTP_INFO(__npages, __start_page, __ops)           \
        .fact_otp = {                                                   \
@@ -526,8 +526,8 @@ struct spinand_info {
        }
 
 #define SPINAND_READ_RETRY(__read_retries, __set_read_retry)           \
-       .read_retries = __read_retries,                         \
-       .set_read_retry = __set_read_retry,
+       .read_retries = __read_retries,                                 \
+       .set_read_retry = __set_read_retry
 
 #define SPINAND_INFO(__model, __id, __memorg, __eccreq, __op_variants, \
                     __flags, ...)                                      \