]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/vmscan: fix comment for isolate_lru_pages
authorMiaohe Lin <linmiaohe@huawei.com>
Fri, 29 Apr 2022 06:16:04 +0000 (23:16 -0700)
committerakpm <akpm@linux-foundation.org>
Fri, 29 Apr 2022 06:16:04 +0000 (23:16 -0700)
Since commit 791b48b64232 ("mm: vmscan: scan until it finds eligible
pages"), splicing any skipped pages to the tail of the LRU list won't put
the system at risk of premature OOM but will waste lots of cpu cycles.
Correct the comment accordingly.

Link: https://lkml.kernel.org/r/20220416025231.8082-1-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: Minchan Kim <minchan@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/vmscan.c

index c5bfbb74fde1dd089c382d282e74a36e1f1e85b9..6e255e2867d2a3a30f0b344549fdf014db325501 100644 (file)
@@ -2117,8 +2117,8 @@ move:
         * Splice any skipped pages to the start of the LRU list. Note that
         * this disrupts the LRU order when reclaiming for lower zones but
         * we cannot splice to the tail. If we did then the SWAP_CLUSTER_MAX
-        * scanning would soon rescan the same pages to skip and put the
-        * system at risk of premature OOM.
+        * scanning would soon rescan the same pages to skip and waste lots
+        * of cpu cycles.
         */
        if (!list_empty(&pages_skipped)) {
                int zid;