]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs: hoist xfs_trans_add_item calls to defer ops functions
authorDarrick J. Wong <djwong@kernel.org>
Mon, 15 Apr 2024 23:07:32 +0000 (16:07 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Wed, 17 Apr 2024 21:06:23 +0000 (14:06 -0700)
Source kernel commit: b28852a5bd08654634e4e32eb072fba14c5fae26

Remove even more repeated boilerplate.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>
libxfs/xfs_defer.c

index 42e1c9c0c9a40401190f68855407176c8905e4f2..27f9938a08d70cad1452f602eddd8fae615f644c 100644 (file)
@@ -208,6 +208,7 @@ xfs_defer_create_done(
                return;
 
        tp->t_flags |= XFS_TRANS_HAS_INTENT_DONE;
+       xfs_trans_add_item(tp, lip);
        set_bit(XFS_LI_DIRTY, &lip->li_flags);
        dfp->dfp_done = lip;
 }
@@ -236,6 +237,7 @@ xfs_defer_create_intent(
                return PTR_ERR(lip);
 
        tp->t_flags |= XFS_TRANS_DIRTY;
+       xfs_trans_add_item(tp, lip);
        set_bit(XFS_LI_DIRTY, &lip->li_flags);
        dfp->dfp_intent = lip;
        return 1;
@@ -501,8 +503,10 @@ xfs_defer_relog(
                xfs_defer_create_done(*tpp, dfp);
                lip = xfs_trans_item_relog(dfp->dfp_intent, dfp->dfp_done,
                                *tpp);
-               if (lip)
+               if (lip) {
+                       xfs_trans_add_item(*tpp, lip);
                        set_bit(XFS_LI_DIRTY, &lip->li_flags);
+               }
                dfp->dfp_done = NULL;
                dfp->dfp_intent = lip;
        }