+++ /dev/null
-From fc62c3b1977d62e6374fd6e28d371bb42dfa5c9d Mon Sep 17 00:00:00 2001
-From: Dexuan Cui <decui@microsoft.com>
-Date: Sun, 23 Sep 2018 21:10:43 +0000
-Subject: Drivers: hv: kvp: Fix two "this statement may fall through" warnings
-
-From: Dexuan Cui <decui@microsoft.com>
-
-commit fc62c3b1977d62e6374fd6e28d371bb42dfa5c9d upstream.
-
-We don't need to call process_ib_ipinfo() if message->kvp_hdr.operation is
-KVP_OP_GET_IP_INFO in kvp_send_key(), because here we just need to pass on
-the op code from the host to the userspace; when the userspace returns
-the info requested by the host, we pass the info on to the host in
-kvp_respond_to_host() -> process_ob_ipinfo(). BTW, the current buggy code
-actually doesn't cause any harm, because only message->kvp_hdr.operation
-is used by the userspace, in the case of KVP_OP_GET_IP_INFO.
-
-The patch also adds a missing "break;" in kvp_send_key(). BTW, the current
-buggy code actually doesn't cause any harm, because in the case of
-KVP_OP_SET, the unexpected fall-through corrupts
-message->body.kvp_set.data.key_size, but that is not really used: see
-the definition of struct hv_kvp_exchg_msg_value.
-
-Signed-off-by: Dexuan Cui <decui@microsoft.com>
-Cc: K. Y. Srinivasan <kys@microsoft.com>
-Cc: Haiyang Zhang <haiyangz@microsoft.com>
-Cc: Stephen Hemminger <sthemmin@microsoft.com>
-Cc: <Stable@vger.kernel.org>
-Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
----
- drivers/hv/hv_kvp.c | 6 ++++--
- 1 file changed, 4 insertions(+), 2 deletions(-)
-
---- a/drivers/hv/hv_kvp.c
-+++ b/drivers/hv/hv_kvp.c
-@@ -326,7 +326,6 @@ static void process_ib_ipinfo(void *in_m
-
- out->body.kvp_ip_val.dhcp_enabled = in->kvp_ip_val.dhcp_enabled;
-
-- default:
- utf16s_to_utf8s((wchar_t *)in->kvp_ip_val.adapter_id,
- MAX_ADAPTER_ID_SIZE,
- UTF16_LITTLE_ENDIAN,
-@@ -379,7 +378,7 @@ kvp_send_key(struct work_struct *dummy)
- process_ib_ipinfo(in_msg, message, KVP_OP_SET_IP_INFO);
- break;
- case KVP_OP_GET_IP_INFO:
-- process_ib_ipinfo(in_msg, message, KVP_OP_GET_IP_INFO);
-+ /* We only need to pass on message->kvp_hdr.operation. */
- break;
- case KVP_OP_SET:
- switch (in_msg->body.kvp_set.data.value_type) {
-@@ -419,6 +418,9 @@ kvp_send_key(struct work_struct *dummy)
- break;
-
- }
-+
-+ break;
-+
- case KVP_OP_GET:
- message->body.kvp_set.data.key_size =
- utf16s_to_utf8s(
+++ /dev/null
-From fc62c3b1977d62e6374fd6e28d371bb42dfa5c9d Mon Sep 17 00:00:00 2001
-From: Dexuan Cui <decui@microsoft.com>
-Date: Sun, 23 Sep 2018 21:10:43 +0000
-Subject: Drivers: hv: kvp: Fix two "this statement may fall through" warnings
-
-From: Dexuan Cui <decui@microsoft.com>
-
-commit fc62c3b1977d62e6374fd6e28d371bb42dfa5c9d upstream.
-
-We don't need to call process_ib_ipinfo() if message->kvp_hdr.operation is
-KVP_OP_GET_IP_INFO in kvp_send_key(), because here we just need to pass on
-the op code from the host to the userspace; when the userspace returns
-the info requested by the host, we pass the info on to the host in
-kvp_respond_to_host() -> process_ob_ipinfo(). BTW, the current buggy code
-actually doesn't cause any harm, because only message->kvp_hdr.operation
-is used by the userspace, in the case of KVP_OP_GET_IP_INFO.
-
-The patch also adds a missing "break;" in kvp_send_key(). BTW, the current
-buggy code actually doesn't cause any harm, because in the case of
-KVP_OP_SET, the unexpected fall-through corrupts
-message->body.kvp_set.data.key_size, but that is not really used: see
-the definition of struct hv_kvp_exchg_msg_value.
-
-Signed-off-by: Dexuan Cui <decui@microsoft.com>
-Cc: K. Y. Srinivasan <kys@microsoft.com>
-Cc: Haiyang Zhang <haiyangz@microsoft.com>
-Cc: Stephen Hemminger <sthemmin@microsoft.com>
-Cc: <Stable@vger.kernel.org>
-Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
----
- drivers/hv/hv_kvp.c | 6 ++++--
- 1 file changed, 4 insertions(+), 2 deletions(-)
-
---- a/drivers/hv/hv_kvp.c
-+++ b/drivers/hv/hv_kvp.c
-@@ -353,7 +353,6 @@ static void process_ib_ipinfo(void *in_m
-
- out->body.kvp_ip_val.dhcp_enabled = in->kvp_ip_val.dhcp_enabled;
-
-- default:
- utf16s_to_utf8s((wchar_t *)in->kvp_ip_val.adapter_id,
- MAX_ADAPTER_ID_SIZE,
- UTF16_LITTLE_ENDIAN,
-@@ -406,7 +405,7 @@ kvp_send_key(struct work_struct *dummy)
- process_ib_ipinfo(in_msg, message, KVP_OP_SET_IP_INFO);
- break;
- case KVP_OP_GET_IP_INFO:
-- process_ib_ipinfo(in_msg, message, KVP_OP_GET_IP_INFO);
-+ /* We only need to pass on message->kvp_hdr.operation. */
- break;
- case KVP_OP_SET:
- switch (in_msg->body.kvp_set.data.value_type) {
-@@ -446,6 +445,9 @@ kvp_send_key(struct work_struct *dummy)
- break;
-
- }
-+
-+ break;
-+
- case KVP_OP_GET:
- message->body.kvp_set.data.key_size =
- utf16s_to_utf8s(
+++ /dev/null
-From fc62c3b1977d62e6374fd6e28d371bb42dfa5c9d Mon Sep 17 00:00:00 2001
-From: Dexuan Cui <decui@microsoft.com>
-Date: Sun, 23 Sep 2018 21:10:43 +0000
-Subject: Drivers: hv: kvp: Fix two "this statement may fall through" warnings
-
-From: Dexuan Cui <decui@microsoft.com>
-
-commit fc62c3b1977d62e6374fd6e28d371bb42dfa5c9d upstream.
-
-We don't need to call process_ib_ipinfo() if message->kvp_hdr.operation is
-KVP_OP_GET_IP_INFO in kvp_send_key(), because here we just need to pass on
-the op code from the host to the userspace; when the userspace returns
-the info requested by the host, we pass the info on to the host in
-kvp_respond_to_host() -> process_ob_ipinfo(). BTW, the current buggy code
-actually doesn't cause any harm, because only message->kvp_hdr.operation
-is used by the userspace, in the case of KVP_OP_GET_IP_INFO.
-
-The patch also adds a missing "break;" in kvp_send_key(). BTW, the current
-buggy code actually doesn't cause any harm, because in the case of
-KVP_OP_SET, the unexpected fall-through corrupts
-message->body.kvp_set.data.key_size, but that is not really used: see
-the definition of struct hv_kvp_exchg_msg_value.
-
-Signed-off-by: Dexuan Cui <decui@microsoft.com>
-Cc: K. Y. Srinivasan <kys@microsoft.com>
-Cc: Haiyang Zhang <haiyangz@microsoft.com>
-Cc: Stephen Hemminger <sthemmin@microsoft.com>
-Cc: <Stable@vger.kernel.org>
-Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
----
- drivers/hv/hv_kvp.c | 6 ++++--
- 1 file changed, 4 insertions(+), 2 deletions(-)
-
---- a/drivers/hv/hv_kvp.c
-+++ b/drivers/hv/hv_kvp.c
-@@ -353,7 +353,6 @@ static void process_ib_ipinfo(void *in_m
-
- out->body.kvp_ip_val.dhcp_enabled = in->kvp_ip_val.dhcp_enabled;
-
-- default:
- utf16s_to_utf8s((wchar_t *)in->kvp_ip_val.adapter_id,
- MAX_ADAPTER_ID_SIZE,
- UTF16_LITTLE_ENDIAN,
-@@ -406,7 +405,7 @@ kvp_send_key(struct work_struct *dummy)
- process_ib_ipinfo(in_msg, message, KVP_OP_SET_IP_INFO);
- break;
- case KVP_OP_GET_IP_INFO:
-- process_ib_ipinfo(in_msg, message, KVP_OP_GET_IP_INFO);
-+ /* We only need to pass on message->kvp_hdr.operation. */
- break;
- case KVP_OP_SET:
- switch (in_msg->body.kvp_set.data.value_type) {
-@@ -446,6 +445,9 @@ kvp_send_key(struct work_struct *dummy)
- break;
-
- }
-+
-+ break;
-+
- case KVP_OP_GET:
- message->body.kvp_set.data.key_size =
- utf16s_to_utf8s(
+++ /dev/null
-From fc62c3b1977d62e6374fd6e28d371bb42dfa5c9d Mon Sep 17 00:00:00 2001
-From: Dexuan Cui <decui@microsoft.com>
-Date: Sun, 23 Sep 2018 21:10:43 +0000
-Subject: Drivers: hv: kvp: Fix two "this statement may fall through" warnings
-
-From: Dexuan Cui <decui@microsoft.com>
-
-commit fc62c3b1977d62e6374fd6e28d371bb42dfa5c9d upstream.
-
-We don't need to call process_ib_ipinfo() if message->kvp_hdr.operation is
-KVP_OP_GET_IP_INFO in kvp_send_key(), because here we just need to pass on
-the op code from the host to the userspace; when the userspace returns
-the info requested by the host, we pass the info on to the host in
-kvp_respond_to_host() -> process_ob_ipinfo(). BTW, the current buggy code
-actually doesn't cause any harm, because only message->kvp_hdr.operation
-is used by the userspace, in the case of KVP_OP_GET_IP_INFO.
-
-The patch also adds a missing "break;" in kvp_send_key(). BTW, the current
-buggy code actually doesn't cause any harm, because in the case of
-KVP_OP_SET, the unexpected fall-through corrupts
-message->body.kvp_set.data.key_size, but that is not really used: see
-the definition of struct hv_kvp_exchg_msg_value.
-
-Signed-off-by: Dexuan Cui <decui@microsoft.com>
-Cc: K. Y. Srinivasan <kys@microsoft.com>
-Cc: Haiyang Zhang <haiyangz@microsoft.com>
-Cc: Stephen Hemminger <sthemmin@microsoft.com>
-Cc: <Stable@vger.kernel.org>
-Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
----
- drivers/hv/hv_kvp.c | 6 ++++--
- 1 file changed, 4 insertions(+), 2 deletions(-)
-
---- a/drivers/hv/hv_kvp.c
-+++ b/drivers/hv/hv_kvp.c
-@@ -353,7 +353,6 @@ static void process_ib_ipinfo(void *in_m
-
- out->body.kvp_ip_val.dhcp_enabled = in->kvp_ip_val.dhcp_enabled;
-
-- default:
- utf16s_to_utf8s((wchar_t *)in->kvp_ip_val.adapter_id,
- MAX_ADAPTER_ID_SIZE,
- UTF16_LITTLE_ENDIAN,
-@@ -406,7 +405,7 @@ kvp_send_key(struct work_struct *dummy)
- process_ib_ipinfo(in_msg, message, KVP_OP_SET_IP_INFO);
- break;
- case KVP_OP_GET_IP_INFO:
-- process_ib_ipinfo(in_msg, message, KVP_OP_GET_IP_INFO);
-+ /* We only need to pass on message->kvp_hdr.operation. */
- break;
- case KVP_OP_SET:
- switch (in_msg->body.kvp_set.data.value_type) {
-@@ -446,6 +445,9 @@ kvp_send_key(struct work_struct *dummy)
- break;
-
- }
-+
-+ break;
-+
- case KVP_OP_GET:
- message->body.kvp_set.data.key_size =
- utf16s_to_utf8s(
+++ /dev/null
-From fc62c3b1977d62e6374fd6e28d371bb42dfa5c9d Mon Sep 17 00:00:00 2001
-From: Dexuan Cui <decui@microsoft.com>
-Date: Sun, 23 Sep 2018 21:10:43 +0000
-Subject: Drivers: hv: kvp: Fix two "this statement may fall through" warnings
-
-From: Dexuan Cui <decui@microsoft.com>
-
-commit fc62c3b1977d62e6374fd6e28d371bb42dfa5c9d upstream.
-
-We don't need to call process_ib_ipinfo() if message->kvp_hdr.operation is
-KVP_OP_GET_IP_INFO in kvp_send_key(), because here we just need to pass on
-the op code from the host to the userspace; when the userspace returns
-the info requested by the host, we pass the info on to the host in
-kvp_respond_to_host() -> process_ob_ipinfo(). BTW, the current buggy code
-actually doesn't cause any harm, because only message->kvp_hdr.operation
-is used by the userspace, in the case of KVP_OP_GET_IP_INFO.
-
-The patch also adds a missing "break;" in kvp_send_key(). BTW, the current
-buggy code actually doesn't cause any harm, because in the case of
-KVP_OP_SET, the unexpected fall-through corrupts
-message->body.kvp_set.data.key_size, but that is not really used: see
-the definition of struct hv_kvp_exchg_msg_value.
-
-Signed-off-by: Dexuan Cui <decui@microsoft.com>
-Cc: K. Y. Srinivasan <kys@microsoft.com>
-Cc: Haiyang Zhang <haiyangz@microsoft.com>
-Cc: Stephen Hemminger <sthemmin@microsoft.com>
-Cc: <Stable@vger.kernel.org>
-Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
----
- drivers/hv/hv_kvp.c | 6 ++++--
- 1 file changed, 4 insertions(+), 2 deletions(-)
-
---- a/drivers/hv/hv_kvp.c
-+++ b/drivers/hv/hv_kvp.c
-@@ -336,7 +336,6 @@ static void process_ib_ipinfo(void *in_m
-
- out->body.kvp_ip_val.dhcp_enabled = in->kvp_ip_val.dhcp_enabled;
-
-- default:
- utf16s_to_utf8s((wchar_t *)in->kvp_ip_val.adapter_id,
- MAX_ADAPTER_ID_SIZE,
- UTF16_LITTLE_ENDIAN,
-@@ -389,7 +388,7 @@ kvp_send_key(struct work_struct *dummy)
- process_ib_ipinfo(in_msg, message, KVP_OP_SET_IP_INFO);
- break;
- case KVP_OP_GET_IP_INFO:
-- process_ib_ipinfo(in_msg, message, KVP_OP_GET_IP_INFO);
-+ /* We only need to pass on message->kvp_hdr.operation. */
- break;
- case KVP_OP_SET:
- switch (in_msg->body.kvp_set.data.value_type) {
-@@ -429,6 +428,9 @@ kvp_send_key(struct work_struct *dummy)
- break;
-
- }
-+
-+ break;
-+
- case KVP_OP_GET:
- message->body.kvp_set.data.key_size =
- utf16s_to_utf8s(
+++ /dev/null
-From fc62c3b1977d62e6374fd6e28d371bb42dfa5c9d Mon Sep 17 00:00:00 2001
-From: Dexuan Cui <decui@microsoft.com>
-Date: Sun, 23 Sep 2018 21:10:43 +0000
-Subject: Drivers: hv: kvp: Fix two "this statement may fall through" warnings
-
-From: Dexuan Cui <decui@microsoft.com>
-
-commit fc62c3b1977d62e6374fd6e28d371bb42dfa5c9d upstream.
-
-We don't need to call process_ib_ipinfo() if message->kvp_hdr.operation is
-KVP_OP_GET_IP_INFO in kvp_send_key(), because here we just need to pass on
-the op code from the host to the userspace; when the userspace returns
-the info requested by the host, we pass the info on to the host in
-kvp_respond_to_host() -> process_ob_ipinfo(). BTW, the current buggy code
-actually doesn't cause any harm, because only message->kvp_hdr.operation
-is used by the userspace, in the case of KVP_OP_GET_IP_INFO.
-
-The patch also adds a missing "break;" in kvp_send_key(). BTW, the current
-buggy code actually doesn't cause any harm, because in the case of
-KVP_OP_SET, the unexpected fall-through corrupts
-message->body.kvp_set.data.key_size, but that is not really used: see
-the definition of struct hv_kvp_exchg_msg_value.
-
-Signed-off-by: Dexuan Cui <decui@microsoft.com>
-Cc: K. Y. Srinivasan <kys@microsoft.com>
-Cc: Haiyang Zhang <haiyangz@microsoft.com>
-Cc: Stephen Hemminger <sthemmin@microsoft.com>
-Cc: <Stable@vger.kernel.org>
-Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
----
- drivers/hv/hv_kvp.c | 6 ++++--
- 1 file changed, 4 insertions(+), 2 deletions(-)
-
---- a/drivers/hv/hv_kvp.c
-+++ b/drivers/hv/hv_kvp.c
-@@ -340,7 +340,6 @@ static void process_ib_ipinfo(void *in_m
-
- out->body.kvp_ip_val.dhcp_enabled = in->kvp_ip_val.dhcp_enabled;
-
-- default:
- utf16s_to_utf8s((wchar_t *)in->kvp_ip_val.adapter_id,
- MAX_ADAPTER_ID_SIZE,
- UTF16_LITTLE_ENDIAN,
-@@ -393,7 +392,7 @@ kvp_send_key(struct work_struct *dummy)
- process_ib_ipinfo(in_msg, message, KVP_OP_SET_IP_INFO);
- break;
- case KVP_OP_GET_IP_INFO:
-- process_ib_ipinfo(in_msg, message, KVP_OP_GET_IP_INFO);
-+ /* We only need to pass on message->kvp_hdr.operation. */
- break;
- case KVP_OP_SET:
- switch (in_msg->body.kvp_set.data.value_type) {
-@@ -433,6 +432,9 @@ kvp_send_key(struct work_struct *dummy)
- break;
-
- }
-+
-+ break;
-+
- case KVP_OP_GET:
- message->body.kvp_set.data.key_size =
- utf16s_to_utf8s(
projects / thirdparty / kernel / stable-queue.git / commitdiff
