]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: mac80211_hwsim: fix warning
authorJohannes Berg <johannes.berg@intel.com>
Fri, 5 Jul 2024 11:39:21 +0000 (13:39 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 8 Jul 2024 16:28:47 +0000 (18:28 +0200)
WARN_ON("string") will unconditionally trigger a warning, but
not really do what it may look like. Use WARN(1, ...) instead
and add the mode number as well.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Link: https://patch.msgid.link/20240705133921.a50aa5b15ece.I9a25b7448b0498c0c2e503986978dae165c8bdf8@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/virtual/mac80211_hwsim.c

index 8491eb32f7603043ad3995b023e2fe829a296268..d60c780d4e8a472593e748931e4382570229d294 100644 (file)
@@ -3261,7 +3261,7 @@ static int mac80211_hwsim_switch_vif_chanctx(struct ieee80211_hw *hw,
                        hwsim_clear_chanctx_magic(vifs[i].old_ctx);
                        break;
                default:
-                       WARN_ON("Invalid mode");
+                       WARN(1, "Invalid mode %d\n", mode);
                }
        }
        return 0;