]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
misc: hisi_hikey_usb: use PTR_ERR_OR_ZERO
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Mon, 26 Oct 2020 18:00:26 +0000 (18:00 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 07:37:29 +0000 (08:37 +0100)
Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code,
we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then
doing 'return 0'.

Tested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Link: https://lore.kernel.org/r/20201026180026.3350-1-sudipm.mukherjee@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/hisi_hikey_usb.c

index cc93569e601c86c41cb9c0ee4467b8adfe719e64..989d7d129469cfa2d2613344fc9a1ce97824ff16 100644 (file)
@@ -168,10 +168,7 @@ static int hisi_hikey_usb_parse_kirin970(struct platform_device *pdev,
 
        hisi_hikey_usb->reset = devm_gpiod_get(&pdev->dev, "hub_reset_en_gpio",
                                               GPIOD_OUT_HIGH);
-       if (IS_ERR(hisi_hikey_usb->reset))
-               return PTR_ERR(hisi_hikey_usb->reset);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(hisi_hikey_usb->reset);
 }
 
 static int hisi_hikey_usb_probe(struct platform_device *pdev)