]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
interconnect: mediatek: Add MediaTek MT8183/8195 EMI Interconnect driver
authorAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Mon, 10 Jun 2024 08:57:35 +0000 (10:57 +0200)
committerGeorgi Djakov <djakov@kernel.org>
Thu, 13 Jun 2024 11:31:43 +0000 (14:31 +0300)
Add an interconnect driver for the External Memory Interface (EMI),
voting for bus bandwidth over the Dynamic Voltage and Frequency Scaling
Resource Collector (DVFSRC).

             ICC provider         ICC Nodes
                              ----          ----
             ---------       |CPU |   |--- |VPU |
    -----   |         |-----  ----    |     ----
   |DRAM |--|DRAM     |       ----    |     ----
   |     |--|scheduler|----- |GPU |   |--- |DISP|
   |     |--|(EMI)    |       ----    |     ----
   |     |--|         |       -----   |     ----
    -----   |         |----- |MMSYS|--|--- |VDEC|
             ---------        -----   |     ----
               /|\                    |     ----
                |change DRAM freq     |--- |VENC|
             ----------               |     ----
            |  DVFSR   |              |
            |          |              |     ----
             ----------               |--- |IMG |
                                      |     ----
                                      |     ----
                                      |--- |CAM |
                                            ----

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20240610085735.147134-8-angelogioacchino.delregno@collabora.com
Signed-off-by: Georgi Djakov <djakov@kernel.org>
drivers/interconnect/Kconfig
drivers/interconnect/Makefile
drivers/interconnect/mediatek/Kconfig [new file with mode: 0644]
drivers/interconnect/mediatek/Makefile [new file with mode: 0644]
drivers/interconnect/mediatek/icc-emi.c [new file with mode: 0644]
drivers/interconnect/mediatek/icc-emi.h [new file with mode: 0644]
drivers/interconnect/mediatek/mt8183.c [new file with mode: 0644]
drivers/interconnect/mediatek/mt8195.c [new file with mode: 0644]

index 5faa8d2aecff42031c300c62945debbafb7e17e5..f2e49bd97d31888ca5c28fdad0339f00b551a500 100644 (file)
@@ -12,6 +12,7 @@ menuconfig INTERCONNECT
 if INTERCONNECT
 
 source "drivers/interconnect/imx/Kconfig"
+source "drivers/interconnect/mediatek/Kconfig"
 source "drivers/interconnect/qcom/Kconfig"
 source "drivers/interconnect/samsung/Kconfig"
 
index d0888babb9a1572d1f1b3c351ff7fec13bbfaac7..b0a9a6753b9dc30083781163ccc01dafcfcd0485 100644 (file)
@@ -5,6 +5,7 @@ icc-core-objs                           := core.o bulk.o debugfs-client.o
 
 obj-$(CONFIG_INTERCONNECT)             += icc-core.o
 obj-$(CONFIG_INTERCONNECT_IMX)         += imx/
+obj-$(CONFIG_INTERCONNECT_MTK)         += mediatek/
 obj-$(CONFIG_INTERCONNECT_QCOM)                += qcom/
 obj-$(CONFIG_INTERCONNECT_SAMSUNG)     += samsung/
 
diff --git a/drivers/interconnect/mediatek/Kconfig b/drivers/interconnect/mediatek/Kconfig
new file mode 100644 (file)
index 0000000..985c849
--- /dev/null
@@ -0,0 +1,29 @@
+# SPDX-License-Identifier: GPL-2.0-only
+
+config INTERCONNECT_MTK
+       bool "MediaTek interconnect drivers"
+       depends on ARCH_MEDIATEK || COMPILE_TEST
+       help
+         Support for MediaTek's bus interconnect hardware.
+
+config INTERCONNECT_MTK_DVFSRC_EMI
+       tristate "MediaTek DVFSRC EMI interconnect driver"
+       depends on INTERCONNECT_MTK && MTK_DVFSRC
+       help
+         This is a driver for the MediaTek External Memory Interface
+         interconnect on SoCs equipped with the integrated Dynamic
+         Voltage Frequency Scaling Resource Collector (DVFSRC) MCU
+
+config INTERCONNECT_MTK_MT8183
+       tristate "MediaTek MT8183 interconnect driver"
+       depends on INTERCONNECT_MTK_DVFSRC_EMI
+       help
+         This is a driver for the MediaTek bus interconnect on MT8183-based
+         platforms.
+
+config INTERCONNECT_MTK_MT8195
+       tristate "MediaTek MT8195 interconnect driver"
+       depends on INTERCONNECT_MTK_DVFSRC_EMI
+       help
+         This is a driver for the MediaTek bus interconnect on MT8195-based
+         platforms.
diff --git a/drivers/interconnect/mediatek/Makefile b/drivers/interconnect/mediatek/Makefile
new file mode 100644 (file)
index 0000000..8e2283a
--- /dev/null
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0
+
+obj-$(CONFIG_INTERCONNECT_MTK_DVFSRC_EMI) += icc-emi.o
+obj-$(CONFIG_INTERCONNECT_MTK_MT8183) += mt8183.o
+obj-$(CONFIG_INTERCONNECT_MTK_MT8195) += mt8195.o
diff --git a/drivers/interconnect/mediatek/icc-emi.c b/drivers/interconnect/mediatek/icc-emi.c
new file mode 100644 (file)
index 0000000..d420c55
--- /dev/null
@@ -0,0 +1,153 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * MediaTek External Memory Interface (EMI) Interconnect driver
+ *
+ * Copyright (c) 2021 MediaTek Inc.
+ * Copyright (c) 2024 Collabora Ltd.
+ *                    AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
+ */
+
+#include <linux/interconnect.h>
+#include <linux/interconnect-provider.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
+#include <linux/platform_device.h>
+#include <linux/soc/mediatek/dvfsrc.h>
+
+#include "icc-emi.h"
+
+static int mtk_emi_icc_aggregate(struct icc_node *node, u32 tag, u32 avg_bw,
+                                u32 peak_bw, u32 *agg_avg, u32 *agg_peak)
+{
+       struct mtk_icc_node *in = node->data;
+
+       *agg_avg += avg_bw;
+       *agg_peak = max_t(u32, *agg_peak, peak_bw);
+
+       in->sum_avg = *agg_avg;
+       in->max_peak = *agg_peak;
+
+       return 0;
+}
+
+static int mtk_emi_icc_set(struct icc_node *src, struct icc_node *dst)
+{
+       struct mtk_icc_node *node = dst->data;
+       struct device *dev;
+       int ret;
+
+       if (unlikely(!src->provider))
+               return -EINVAL;
+
+       dev = src->provider->dev;
+
+       switch (node->ep) {
+       case 0:
+               break;
+       case 1:
+               ret = mtk_dvfsrc_send_request(dev, MTK_DVFSRC_CMD_PEAK_BW, node->max_peak);
+               if (ret) {
+                       dev_err(dev, "Cannot send peak bw request: %d\n", ret);
+                       return ret;
+               }
+
+               ret = mtk_dvfsrc_send_request(dev, MTK_DVFSRC_CMD_BW, node->sum_avg);
+               if (ret) {
+                       dev_err(dev, "Cannot send bw request: %d\n", ret);
+                       return ret;
+               }
+               break;
+       case 2:
+               ret = mtk_dvfsrc_send_request(dev, MTK_DVFSRC_CMD_HRT_BW, node->sum_avg);
+               if (ret) {
+                       dev_err(dev, "Cannot send HRT bw request: %d\n", ret);
+                       return ret;
+               }
+               break;
+       default:
+               dev_err(src->provider->dev, "Unknown endpoint %u\n", node->ep);
+               return -EINVAL;
+       };
+
+       return 0;
+}
+
+int mtk_emi_icc_probe(struct platform_device *pdev)
+{
+       const struct mtk_icc_desc *desc;
+       struct device *dev = &pdev->dev;
+       struct icc_node *node;
+       struct icc_onecell_data *data;
+       struct icc_provider *provider;
+       struct mtk_icc_node **mnodes;
+       int i, j, ret;
+
+       desc = of_device_get_match_data(dev);
+       if (!desc)
+               return -EINVAL;
+
+       mnodes = desc->nodes;
+
+       provider = devm_kzalloc(dev, sizeof(*provider), GFP_KERNEL);
+       if (!provider)
+               return -ENOMEM;
+
+       data = devm_kzalloc(dev, struct_size(data, nodes, desc->num_nodes), GFP_KERNEL);
+       if (!data)
+               return -ENOMEM;
+
+       provider->dev = pdev->dev.parent;
+       provider->set = mtk_emi_icc_set;
+       provider->aggregate = mtk_emi_icc_aggregate;
+       provider->xlate = of_icc_xlate_onecell;
+       INIT_LIST_HEAD(&provider->nodes);
+       provider->data = data;
+
+       for (i = 0; i < desc->num_nodes; i++) {
+               if (!mnodes[i])
+                       continue;
+
+               node = icc_node_create(mnodes[i]->id);
+               if (IS_ERR(node)) {
+                       ret = PTR_ERR(node);
+                       goto err;
+               }
+
+               node->name = mnodes[i]->name;
+               node->data = mnodes[i];
+               icc_node_add(node, provider);
+
+               for (j = 0; j < mnodes[i]->num_links; j++)
+                       icc_link_create(node, mnodes[i]->links[j]);
+
+               data->nodes[i] = node;
+       }
+       data->num_nodes = desc->num_nodes;
+
+       ret = icc_provider_register(provider);
+       if (ret)
+               goto err;
+
+       platform_set_drvdata(pdev, provider);
+
+       return 0;
+err:
+       icc_nodes_remove(provider);
+       return ret;
+}
+EXPORT_SYMBOL_GPL(mtk_emi_icc_probe);
+
+void mtk_emi_icc_remove(struct platform_device *pdev)
+{
+       struct icc_provider *provider = platform_get_drvdata(pdev);
+
+       icc_provider_deregister(provider);
+       icc_nodes_remove(provider);
+}
+EXPORT_SYMBOL_GPL(mtk_emi_icc_remove);
+
+MODULE_AUTHOR("AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>");
+MODULE_AUTHOR("Henry Chen <henryc.chen@mediatek.com>");
+MODULE_DESCRIPTION("MediaTek External Memory Interface interconnect driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/interconnect/mediatek/icc-emi.h b/drivers/interconnect/mediatek/icc-emi.h
new file mode 100644 (file)
index 0000000..9512a50
--- /dev/null
@@ -0,0 +1,40 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2021 MediaTek Inc.
+ * Copyright (c) 2024 Collabora Ltd.
+ *                    AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
+ */
+
+#ifndef __DRIVERS_INTERCONNECT_MEDIATEK_ICC_EMI_H
+#define __DRIVERS_INTERCONNECT_MEDIATEK_ICC_EMI_H
+
+/**
+ * struct mtk_icc_node - Mediatek EMI Interconnect Node
+ * @name:      The interconnect node name which is shown in debugfs
+ * @ep:        Type of this endpoint
+ * @id:        Unique node identifier
+ * @sum_avg:   Current sum aggregate value of all average bw requests in kBps
+ * @max_peak:  Current max aggregate value of all peak bw requests in kBps
+ * @num_links: The total number of @links
+ * @links:     Array of @id linked to this node
+ */
+struct mtk_icc_node {
+       unsigned char *name;
+       int ep;
+       u16 id;
+       u64 sum_avg;
+       u64 max_peak;
+
+       u16 num_links;
+       u16 links[] __counted_by(num_links);
+};
+
+struct mtk_icc_desc {
+       struct mtk_icc_node **nodes;
+       size_t num_nodes;
+};
+
+int mtk_emi_icc_probe(struct platform_device *pdev);
+void mtk_emi_icc_remove(struct platform_device *pdev);
+
+#endif /* __DRIVERS_INTERCONNECT_MEDIATEK_ICC_EMI_H */
diff --git a/drivers/interconnect/mediatek/mt8183.c b/drivers/interconnect/mediatek/mt8183.c
new file mode 100644 (file)
index 0000000..2424508
--- /dev/null
@@ -0,0 +1,143 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2021 MediaTek Inc.
+ * Copyright (c) 2024 Collabora Ltd.
+ *                    AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
+ */
+
+#include <linux/device.h>
+#include <linux/interconnect.h>
+#include <linux/interconnect-provider.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <dt-bindings/interconnect/mediatek,mt8183.h>
+
+#include "icc-emi.h"
+
+static struct mtk_icc_node ddr_emi = {
+       .name = "ddr-emi",
+       .id = SLAVE_DDR_EMI,
+       .ep = 1,
+};
+
+static struct mtk_icc_node mcusys = {
+       .name = "mcusys",
+       .id = MASTER_MCUSYS,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node gpu = {
+       .name = "gpu",
+       .id = MASTER_MFG,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node mmsys = {
+       .name = "mmsys",
+       .id = MASTER_MMSYS,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node mm_vpu = {
+       .name = "mm-vpu",
+       .id = MASTER_MM_VPU,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node mm_disp = {
+       .name = "mm-disp",
+       .id = MASTER_MM_DISP,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node mm_vdec = {
+       .name = "mm-vdec",
+       .id = MASTER_MM_VDEC,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node mm_venc = {
+       .name = "mm-venc",
+       .id = MASTER_MM_VENC,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node mm_cam = {
+       .name = "mm-cam",
+       .id = MASTER_MM_CAM,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node mm_img = {
+       .name = "mm-img",
+       .id = MASTER_MM_IMG,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node mm_mdp = {
+       .name = "mm-mdp",
+       .id = MASTER_MM_MDP,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node *mt8183_emi_icc_nodes[] = {
+       [SLAVE_DDR_EMI] = &ddr_emi,
+       [MASTER_MCUSYS] = &mcusys,
+       [MASTER_MFG] = &gpu,
+       [MASTER_MMSYS] = &mmsys,
+       [MASTER_MM_VPU] = &mm_vpu,
+       [MASTER_MM_DISP] = &mm_disp,
+       [MASTER_MM_VDEC] = &mm_vdec,
+       [MASTER_MM_VENC] = &mm_venc,
+       [MASTER_MM_CAM] = &mm_cam,
+       [MASTER_MM_IMG] = &mm_img,
+       [MASTER_MM_MDP] = &mm_mdp
+};
+
+static const struct mtk_icc_desc mt8183_emi_icc = {
+       .nodes = mt8183_emi_icc_nodes,
+       .num_nodes = ARRAY_SIZE(mt8183_emi_icc_nodes),
+};
+
+static const struct of_device_id mtk_mt8183_emi_icc_of_match[] = {
+       { .compatible = "mediatek,mt8183-emi", .data = &mt8183_emi_icc },
+       { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, mtk_mt8183_emi_icc_of_match);
+
+static struct platform_driver mtk_emi_icc_mt8183_driver = {
+       .driver = {
+               .name = "emi-icc-mt8183",
+               .of_match_table = mtk_mt8183_emi_icc_of_match,
+               .sync_state = icc_sync_state,
+       },
+       .probe = mtk_emi_icc_probe,
+       .remove_new = mtk_emi_icc_remove,
+
+};
+module_platform_driver(mtk_emi_icc_mt8183_driver);
+
+MODULE_AUTHOR("AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>");
+MODULE_DESCRIPTION("MediaTek MT8183 EMI ICC driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/interconnect/mediatek/mt8195.c b/drivers/interconnect/mediatek/mt8195.c
new file mode 100644 (file)
index 0000000..710e14c
--- /dev/null
@@ -0,0 +1,339 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2021 MediaTek Inc.
+ * Copyright (c) 2024 Collabora Ltd.
+ *                    AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
+ */
+
+#include <linux/device.h>
+#include <linux/interconnect.h>
+#include <linux/interconnect-provider.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <dt-bindings/interconnect/mediatek,mt8195.h>
+
+#include "icc-emi.h"
+
+static struct mtk_icc_node ddr_emi = {
+       .name = "ddr-emi",
+       .id = SLAVE_DDR_EMI,
+       .ep = 1,
+};
+
+static struct mtk_icc_node mcusys = {
+       .name = "mcusys",
+       .id = MASTER_MCUSYS,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node gpu = {
+       .name = "gpu",
+       .id = MASTER_GPUSYS,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node mmsys = {
+       .name = "mmsys",
+       .id = MASTER_MMSYS,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node mm_vpu = {
+       .name = "mm-vpu",
+       .id = MASTER_MM_VPU,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node mm_disp = {
+       .name = "mm-disp",
+       .id = MASTER_MM_DISP,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node mm_vdec = {
+       .name = "mm-vdec",
+       .id = MASTER_MM_VDEC,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node mm_venc = {
+       .name = "mm-venc",
+       .id = MASTER_MM_VENC,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node mm_cam = {
+       .name = "mm-cam",
+       .id = MASTER_MM_CAM,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node mm_img = {
+       .name = "mm-img",
+       .id = MASTER_MM_IMG,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node mm_mdp = {
+       .name = "mm-mdp",
+       .id = MASTER_MM_MDP,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MMSYS }
+};
+
+static struct mtk_icc_node vpusys = {
+       .name = "vpusys",
+       .id = MASTER_VPUSYS,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node vpu_port0 = {
+       .name = "vpu-port0",
+       .id = MASTER_VPU_0,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_VPUSYS }
+};
+
+static struct mtk_icc_node vpu_port1 = {
+       .name = "vpu-port1",
+       .id = MASTER_VPU_1,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_VPUSYS }
+};
+
+static struct mtk_icc_node mdlasys = {
+       .name = "mdlasys",
+       .id = MASTER_MDLASYS,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node mdla_port0 = {
+       .name = "mdla-port0",
+       .id = MASTER_MDLA_0,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_MDLASYS }
+};
+
+static struct mtk_icc_node ufs = {
+       .name = "ufs",
+       .id = MASTER_UFS,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node pcie0 = {
+       .name = "pcie0",
+       .id = MASTER_PCIE_0,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node pcie1 = {
+       .name = "pcie1",
+       .id = MASTER_PCIE_1,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node usb = {
+       .name = "usb",
+       .id = MASTER_USB,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node wifi = {
+       .name = "wifi",
+       .id = MASTER_WIFI,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node bt = {
+       .name = "bt",
+       .id = MASTER_BT,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node netsys = {
+       .name = "netsys",
+       .id = MASTER_NETSYS,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node dbgif = {
+       .name = "dbgif",
+       .id = MASTER_DBGIF,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_DDR_EMI }
+};
+
+static struct mtk_icc_node hrt_ddr_emi = {
+       .name = "hrt-ddr-emi",
+       .id = SLAVE_HRT_DDR_EMI,
+       .ep = 2,
+};
+
+static struct mtk_icc_node hrt_mmsys = {
+       .name = "hrt-mmsys",
+       .id = MASTER_HRT_MMSYS,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_HRT_DDR_EMI }
+};
+
+static struct mtk_icc_node hrt_mm_disp = {
+       .name = "hrt-mm-disp",
+       .id = MASTER_HRT_MM_DISP,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_HRT_MMSYS }
+};
+
+static struct mtk_icc_node hrt_mm_vdec = {
+       .name = "hrt-mm-vdec",
+       .id = MASTER_HRT_MM_VDEC,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_HRT_MMSYS }
+};
+
+static struct mtk_icc_node hrt_mm_venc = {
+       .name = "hrt-mm-venc",
+       .id = MASTER_HRT_MM_VENC,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_HRT_MMSYS }
+};
+
+static struct mtk_icc_node hrt_mm_cam = {
+       .name = "hrt-mm-cam",
+       .id = MASTER_HRT_MM_CAM,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_HRT_MMSYS }
+};
+
+static struct mtk_icc_node hrt_mm_img = {
+       .name = "hrt-mm-img",
+       .id = MASTER_HRT_MM_IMG,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_HRT_MMSYS }
+};
+
+static struct mtk_icc_node hrt_mm_mdp = {
+       .name = "hrt-mm-mdp",
+       .id = MASTER_HRT_MM_MDP,
+       .ep = 0,
+       .num_links = 1,
+       .links = { MASTER_HRT_MMSYS }
+};
+
+static struct mtk_icc_node hrt_dbgif = {
+       .name = "hrt-dbgif",
+       .id = MASTER_HRT_DBGIF,
+       .ep = 0,
+       .num_links = 1,
+       .links = { SLAVE_HRT_DDR_EMI }
+};
+
+static struct mtk_icc_node *mt8195_emi_icc_nodes[] = {
+       [SLAVE_DDR_EMI] = &ddr_emi,
+       [MASTER_MCUSYS] = &mcusys,
+       [MASTER_GPUSYS] = &gpu,
+       [MASTER_MMSYS] = &mmsys,
+       [MASTER_MM_VPU] = &mm_vpu,
+       [MASTER_MM_DISP] = &mm_disp,
+       [MASTER_MM_VDEC] = &mm_vdec,
+       [MASTER_MM_VENC] = &mm_venc,
+       [MASTER_MM_CAM] = &mm_cam,
+       [MASTER_MM_IMG] = &mm_img,
+       [MASTER_MM_MDP] = &mm_mdp,
+       [MASTER_VPUSYS] = &vpusys,
+       [MASTER_VPU_0] = &vpu_port0,
+       [MASTER_VPU_1] = &vpu_port1,
+       [MASTER_MDLASYS] = &mdlasys,
+       [MASTER_MDLA_0] = &mdla_port0,
+       [MASTER_UFS] = &ufs,
+       [MASTER_PCIE_0] = &pcie0,
+       [MASTER_PCIE_1] = &pcie1,
+       [MASTER_USB] = &usb,
+       [MASTER_WIFI] = &wifi,
+       [MASTER_BT] = &bt,
+       [MASTER_NETSYS] = &netsys,
+       [MASTER_DBGIF] = &dbgif,
+       [SLAVE_HRT_DDR_EMI] = &hrt_ddr_emi,
+       [MASTER_HRT_MMSYS] = &hrt_mmsys,
+       [MASTER_HRT_MM_DISP] = &hrt_mm_disp,
+       [MASTER_HRT_MM_VDEC] = &hrt_mm_vdec,
+       [MASTER_HRT_MM_VENC] = &hrt_mm_venc,
+       [MASTER_HRT_MM_CAM] = &hrt_mm_cam,
+       [MASTER_HRT_MM_IMG] = &hrt_mm_img,
+       [MASTER_HRT_MM_MDP] = &hrt_mm_mdp,
+       [MASTER_HRT_DBGIF] = &hrt_dbgif
+};
+
+static struct mtk_icc_desc mt8195_emi_icc = {
+       .nodes = mt8195_emi_icc_nodes,
+       .num_nodes = ARRAY_SIZE(mt8195_emi_icc_nodes),
+};
+
+static const struct of_device_id mtk_mt8195_emi_icc_of_match[] = {
+       { .compatible = "mediatek,mt8195-emi", .data = &mt8195_emi_icc },
+       { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, mtk_mt8195_emi_icc_of_match);
+
+static struct platform_driver mtk_emi_icc_mt8195_driver = {
+       .driver = {
+               .name = "emi-icc-mt8195",
+               .of_match_table = mtk_mt8195_emi_icc_of_match,
+               .sync_state = icc_sync_state,
+       },
+       .probe = mtk_emi_icc_probe,
+       .remove_new = mtk_emi_icc_remove,
+
+};
+module_platform_driver(mtk_emi_icc_mt8195_driver);
+
+MODULE_AUTHOR("AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>");
+MODULE_DESCRIPTION("MediaTek MT8195 EMI ICC driver");
+MODULE_LICENSE("GPL");