]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
clarify that the mssql password is not a secret 13529/head
authorPeter van Dijk <peter.van.dijk@powerdns.com>
Thu, 23 Nov 2023 12:55:13 +0000 (13:55 +0100)
committerPeter van Dijk <peter.van.dijk@powerdns.com>
Thu, 23 Nov 2023 12:55:13 +0000 (13:55 +0100)
.github/workflows/build-and-test-all.yml
tasks.py

index 5a02ba2f511e649fce229dd3ecfb8c7b9d28603f..4290cda1ed67dd5e21db484c0ef2dfb858cfae32 100644 (file)
@@ -359,7 +359,7 @@ jobs:
             image: mcr.microsoft.com/mssql/server:2017-GA-ubuntu
             env:
               ACCEPT_EULA: Y
-              SA_PASSWORD: 'SAsa12%%'
+              SA_PASSWORD: 'SAsa12%%-not-a-secret-password'
             ports:
               - 1433:1433
           - backend: ldap
index 2d6a987ee0de1d45d3bc89c9f0efad8e09319122..258bb884b40af2e4e2644a48e42100d9b0f76705 100644 (file)
--- a/tasks.py
+++ b/tasks.py
@@ -739,7 +739,7 @@ backend_regress_tests = dict(
     geoip_mmdb = ['geoip'],
 )
 
-godbc_mssql_credentials = {"username": "sa", "password": "SAsa12%%"}
+godbc_mssql_credentials = {"username": "sa", "password": "SAsa12%%-not-a-secret-password"}
 
 godbc_config = f'''
 [pdns-mssql-docker]