]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Fix ACLE data-intrinsics testcases
authorChristophe Lyon <christophe.lyon@linaro.org>
Tue, 30 May 2023 13:45:13 +0000 (13:45 +0000)
committerChristophe Lyon <christophe.lyon@linaro.org>
Tue, 30 May 2023 15:41:32 +0000 (15:41 +0000)
data-intrinsics-assembly.c forces -march=armv6 using dg-add-options
arm_arch_v6, which implicitly adds -mfloat-abi=softfp.

However, for a toolchain configured for arm-linux-gnueabihf and
--with-arch=armv7-a, the testcase will fail when including arm_acle.h
(which includes stdint.h, which will fail to include the non-existing
gnu/stubs-soft.h).

Other effective-targets related to arm_acle.h would also pass because
they first try without -mfloat-abi=softfp, so it seems the
simplest/safest is to add { dg-require-effective-target arm_softfp_ok }
to make sure arm_arch_v6_ok's assumption is valid.

The patch also fixes what seems to be an oversight in
data-intrinsics-armv6.c: it requires arm_arch_v6_ok, but uses
arm_arch_v6t2: the patch makes it require arm_arch_v6t2_ok.

2023-05-30  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/testsuite/
* gcc.target/arm/acle/data-intrinsics-armv6.c: Fix typo.
* gcc.target/arm/acle/data-intrinsics-assembly.c: Require
arm_softfp_ok.

gcc/testsuite/gcc.target/arm/acle/data-intrinsics-armv6.c
gcc/testsuite/gcc.target/arm/acle/data-intrinsics-assembly.c

index aafdff35ceeab109d53ad92fa1f954e6d3b09dd3..988ecac37878f95c636f90bf47cc626cc45282e3 100644 (file)
@@ -1,5 +1,5 @@
 /* { dg-do run } */
-/* { dg-require-effective-target arm_arch_v6_ok } */
+/* { dg-require-effective-target arm_arch_v6t2_ok } */
 /* { dg-add-options arm_arch_v6t2 } */
 
 #include "arm_acle.h"
index 3e066877a70b52f72e6745c0524b9d9f0222a5f3..478cbde1600e7fd7aa33d6121fe71849d250b8e1 100644 (file)
@@ -1,5 +1,6 @@
 /* Test the ACLE data intrinsics get expanded to the correct instructions on a specific architecture  */
 /* { dg-do assemble } */
+/* { dg-require-effective-target arm_softfp_ok } */
 /* { dg-require-effective-target arm_arch_v6_ok } */
 /* { dg-additional-options "--save-temps -O1" } */
 /* { dg-add-options arm_arch_v6 } */