]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
objtool: Add bch2_trans_unlocked_or_in_restart_error() to bcachefs noreturns
authorYouling Tang <tangyouling@kylinos.cn>
Tue, 18 Feb 2025 06:42:30 +0000 (14:42 +0800)
committerJosh Poimboeuf <jpoimboe@kernel.org>
Tue, 25 Feb 2025 18:16:31 +0000 (10:16 -0800)
Fix the following objtool warning during build time:

  fs/bcachefs/btree_cache.o: warning: objtool: btree_node_lock.constprop.0() falls through to next function bch2_recalc_btree_reserve()
  fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function need_whiteout_for_snapshot()

bch2_trans_unlocked_or_in_restart_error() is an Obviously Correct (tm)
panic() wrapper, add it to the list of known noreturns.

Fixes: b318882022a8 ("bcachefs: bch2_trans_verify_not_unlocked_or_in_restart()")
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
Reviewed-by: Kent Overstreet <kent.overstreet@linux.dev>
Link: https://lore.kernel.org/r/20250218064230.219997-1-youling.tang@linux.dev
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
tools/objtool/noreturns.h

index b2174894f9f7133db81225b3ddc17969e3e038cf..6bb7edda3094d39744521a1bebd3d466a2f15288 100644 (file)
@@ -19,7 +19,7 @@ NORETURN(__x64_sys_exit_group)
 NORETURN(arch_cpu_idle_dead)
 NORETURN(bch2_trans_in_restart_error)
 NORETURN(bch2_trans_restart_error)
-NORETURN(bch2_trans_unlocked_error)
+NORETURN(bch2_trans_unlocked_or_in_restart_error)
 NORETURN(cpu_bringup_and_idle)
 NORETURN(cpu_startup_entry)
 NORETURN(do_exit)