]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: fix uninitialized symbol warnings
authorChelsy Ratnawat <chelsyratnawat2001@gmail.com>
Thu, 7 Aug 2025 06:09:36 +0000 (23:09 -0700)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 29 Aug 2025 09:04:02 +0000 (11:04 +0200)
Initialize variables to fix these smatch warnings
drivers/media/i2c/ir-kbd-i2c.c:339 ir_key_poll() error: uninitialized
symbol 'protocol'.
drivers/media/i2c/ir-kbd-i2c.c:339 ir_key_poll() error: uninitialized
symbol 'scancode'.
drivers/media/i2c/ir-kbd-i2c.c:339 ir_key_poll() error: uninitialized
symbol 'toggle'.
drivers/media/tuners/xc4000.c:1102 xc_debug_dump() error: uninitialized
symbol 'adc_envelope'.
drivers/media/tuners/xc4000.c:1108 xc_debug_dump() error: uninitialized
symbol 'lock_status'.
drivers/media/tuners/xc4000.c:1123 xc_debug_dump() error: uninitialized
symbol 'frame_lines'.
drivers/media/tuners/xc4000.c:1127 xc_debug_dump() error: uninitialized
symbol 'quality'.
drivers/media/tuners/xc5000.c:645 xc_debug_dump() error: uninitialized
symbol 'adc_envelope'.
drivers/media/tuners/xc5000.c:651 xc_debug_dump() error: uninitialized
symbol 'lock_status'.
drivers/media/tuners/xc5000.c:665 xc_debug_dump() error: uninitialized
symbol 'frame_lines'.
drivers/media/tuners/xc5000.c:668 xc_debug_dump() error: uninitialized
symbol 'quality'.
drivers/media/tuners/xc5000.c:671 xc_debug_dump() error: uninitialized
symbol 'snr'.
drivers/media/tuners/xc5000.c:674 xc_debug_dump() error: uninitialized
symbol 'totalgain'.

Signed-off-by: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
[hverkuil: dropped ' = 0' from rc in ir-kbd-i2c.c, not needed]

drivers/media/i2c/ir-kbd-i2c.c
drivers/media/tuners/xc4000.c
drivers/media/tuners/xc5000.c

index c84e1e0e6109afccc29c72ee2ac762eaddb0b0ad..5588cdd7ec20de3b32f3ab932436a94bd6607208 100644 (file)
@@ -321,9 +321,9 @@ static int get_key_avermedia_cardbus(struct IR_i2c *ir, enum rc_proto *protocol,
 
 static int ir_key_poll(struct IR_i2c *ir)
 {
-       enum rc_proto protocol;
-       u32 scancode;
-       u8 toggle;
+       enum rc_proto protocol = 0;
+       u32 scancode = 0;
+       u8 toggle = 0;
        int rc;
 
        dev_dbg(&ir->rc->dev, "%s\n", __func__);
index 3cf54d776d36c826f8db2002e3976119803fa43e..b44c97e4e5ec675a6489fe255677562e70b6ffbb 100644 (file)
@@ -1087,12 +1087,12 @@ fail:
 
 static void xc_debug_dump(struct xc4000_priv *priv)
 {
-       u16     adc_envelope;
+       u16     adc_envelope = 0;
        u32     freq_error_hz = 0;
-       u16     lock_status;
+       u16     lock_status = 0;
        u32     hsync_freq_hz = 0;
-       u16     frame_lines;
-       u16     quality;
+       u16     frame_lines = 0;
+       u16     quality = 0;
        u16     signal = 0;
        u16     noise = 0;
        u8      hw_majorversion = 0, hw_minorversion = 0;
index 30aa4ee958bdeabf45a16af9c42d7762bb395895..bf4ff461e08255fe87f3c53478f4bbccd1ee5a4c 100644 (file)
@@ -622,14 +622,14 @@ static int xc5000_fwupload(struct dvb_frontend *fe,
 
 static void xc_debug_dump(struct xc5000_priv *priv)
 {
-       u16 adc_envelope;
+       u16 adc_envelope = 0;
        u32 freq_error_hz = 0;
-       u16 lock_status;
+       u16 lock_status = 0;
        u32 hsync_freq_hz = 0;
-       u16 frame_lines;
-       u16 quality;
-       u16 snr;
-       u16 totalgain;
+       u16 frame_lines = 0;
+       u16 quality = 0;
+       u16 snr = 0;
+       u16 totalgain = 0;
        u8 hw_majorversion = 0, hw_minorversion = 0;
        u8 fw_majorversion = 0, fw_minorversion = 0;
        u16 fw_buildversion = 0;