]> git.ipfire.org Git - thirdparty/nftables.git/commitdiff
parser_bison: memleak in log prefix string
authorPablo Neira Ayuso <pablo@netfilter.org>
Wed, 15 Jul 2020 19:39:39 +0000 (21:39 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 15 Jul 2020 19:56:43 +0000 (21:56 +0200)
Release the string after creating the constant expression.

Fixes: 96c909ef46f0 ("src: allow for variables in the log prefix string")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/parser_bison.y

index 756806d9efdb391e995cab766f67fff0a1e2c951..572e584cfbe48eaeabfd566135d21d3cfcb59d76 100644 (file)
@@ -2676,6 +2676,7 @@ log_arg                   :       PREFIX                  string
                                        expr = constant_expr_alloc(&@$, &string_type,
                                                                   BYTEORDER_HOST_ENDIAN,
                                                                   (strlen($2) + 1) * BITS_PER_BYTE, $2);
+                                       xfree($2);
                                        $<stmt>0->log.prefix = expr;
                                        $<stmt>0->log.flags |= STMT_LOG_PREFIX;
                                        break;