rec: Prevent a copy in RecursorLua4::DNSQuestion::addAnswer

Reported by Coverity as 1509322

(cherry picked from commit 86867a80b19a40644e5d5d1c2dcacccb70695b85)

diff --git a/pdns/recursordist/lua-recursor4.cc b/pdns/recursordist/lua-recursor4.cc
index b35cfd0d943396db77b48c06bd30ee4134b3b8af..04c538025cd58d5c1914d25afb163a6e9d847cd3 100644 (file)
--- a/pdns/recursordist/lua-recursor4.cc
+++ b/pdns/recursordist/lua-recursor4.cc
@@ -140,7 +140,7 @@ void RecursorLua4::DNSQuestion::addRecord(uint16_t type, const std::string& cont
 
 void RecursorLua4::DNSQuestion::addAnswer(uint16_t type, const std::string& content, boost::optional<int> ttl, boost::optional<string> name)
 {
-  addRecord(type, content, DNSResourceRecord::ANSWER, ttl, name);
+  addRecord(type, content, DNSResourceRecord::ANSWER, ttl, std::move(name));
 }
 
 struct DynMetric