]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
CMake: Remove unused 'output_var' from 'collect_true'
authorRuslan Baratov <ruslan_baratov@yahoo.com>
Thu, 5 Jul 2018 10:21:57 +0000 (13:21 +0300)
committerDaniel Stenberg <daniel@haxx.se>
Fri, 6 Jul 2018 07:35:28 +0000 (09:35 +0200)
Variable 'output_var' is not used and can be removed.
Function 'collect_true' renamed to 'count_true'.

CMake/Utilities.cmake
CMakeLists.txt

index 8425bbd7826ea6718343b0b10d89a0101ab4c44b..5cb1d449754bb28a8577350887a7741709998099 100644 (file)
@@ -1,14 +1,13 @@
 # File containing various utilities
 
 # Returns a list of arguments that evaluate to true
-function(collect_true output_var output_count_var)
-  set(${output_var})
+function(count_true output_count_var)
+  set(lst)
   foreach(option_var IN LISTS ARGN)
     if(${option_var})
-      list(APPEND ${output_var} ${option_var})
+      list(APPEND lst ${option_var})
     endif()
   endforeach()
-  set(${output_var} ${${output_var}} PARENT_SCOPE)
-  list(LENGTH ${output_var} ${output_count_var})
-  set(${output_count_var} ${${output_count_var}} PARENT_SCOPE)
+  list(LENGTH lst lst_len)
+  set(${output_count_var} ${lst_len} PARENT_SCOPE)
 endfunction()
index faa9bddd967d34b1420cb6c0190a6ef250355437..cb6db93338ff6458b09187ebac8be6f03bc2ad1e 100644 (file)
@@ -309,13 +309,13 @@ if(WIN32 OR CMAKE_USE_DARWINSSL OR CMAKE_USE_WINSSL OR CMAKE_USE_MBEDTLS)
 endif()
 option(CMAKE_USE_OPENSSL "Use OpenSSL code. Experimental" ${openssl_default})
 
-collect_true(enabled_ssl_options enabled_ssl_options_count
+count_true(enabled_ssl_options_count
   CMAKE_USE_WINSSL
   CMAKE_USE_DARWINSSL
   CMAKE_USE_OPENSSL
   CMAKE_USE_MBEDTLS
 )
-if(enabled_ssl_options_count GREATER 1)
+if(enabled_ssl_options_count GREATER "1")
   set(CURL_WITH_MULTI_SSL ON)
 endif()