]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
usb: cdns3-ti: Add workaround for Errata i2409
authorRoger Quadros <rogerq@kernel.org>
Thu, 16 May 2024 04:45:37 +0000 (10:15 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 4 Jun 2024 13:41:10 +0000 (15:41 +0200)
TI USB2 PHY is known to have a lockup issue on very short
suspend intervals. Enable the Suspend Residency quirk flag to
workaround this as described in Errata i2409 [1].

[1] - https://www.ti.com/lit/er/sprz457h/sprz457h.pdf

Signed-off-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
Acked-by: Peter Chen <peter.chen@kernel.org>
Link: https://lore.kernel.org/r/20240516044537.16801-3-r-gunasekaran@ti.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/cdns3/cdns3-ti.c

index 5945c4b1e11f6a3e20878341e4a893d4ab7794a8..cfabc12ee0e3c02ed95c06604c9be22eb2739955 100644 (file)
@@ -16,6 +16,7 @@
 #include <linux/of_platform.h>
 #include <linux/pm_runtime.h>
 #include <linux/property.h>
+#include "core.h"
 
 /* USB Wrapper register offsets */
 #define USBSS_PID              0x0
@@ -85,6 +86,18 @@ static inline void cdns_ti_writel(struct cdns_ti *data, u32 offset, u32 value)
        writel(value, data->usbss + offset);
 }
 
+static struct cdns3_platform_data cdns_ti_pdata = {
+       .quirks = CDNS3_DRD_SUSPEND_RESIDENCY_ENABLE,   /* Errata i2409 */
+};
+
+static const struct of_dev_auxdata cdns_ti_auxdata[] = {
+       {
+               .compatible = "cdns,usb3",
+               .platform_data = &cdns_ti_pdata,
+       },
+       {},
+};
+
 static int cdns_ti_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
@@ -176,7 +189,7 @@ static int cdns_ti_probe(struct platform_device *pdev)
        reg |= USBSS_W1_PWRUP_RST;
        cdns_ti_writel(data, USBSS_W1, reg);
 
-       error = of_platform_populate(node, NULL, NULL, dev);
+       error = of_platform_populate(node, NULL, cdns_ti_auxdata, dev);
        if (error) {
                dev_err(dev, "failed to create children: %d\n", error);
                goto err;