- misc savepoint test

- don't need dialect_impl() for Text

diff --git a/lib/sqlalchemy/types.py b/lib/sqlalchemy/types.py
index 38aba026c482b4385b523de40e5b964cddb121d0..9ffd4d1831d73503677d9b1d7a0c5631ec18c931 100644 (file)
--- a/lib/sqlalchemy/types.py
+++ b/lib/sqlalchemy/types.py
@@ -485,8 +485,6 @@ class Text(String):
     params (and the reverse for result sets.)
 
     """
-    def dialect_impl(self, dialect, **kwargs):
-        return TypeEngine.dialect_impl(self, dialect, **kwargs)
 
 class Unicode(String):
     """A variable length Unicode string.

diff --git a/test/orm/transaction.py b/test/orm/transaction.py
index 5c3fd8342d24b0c871cb69d814a844b6c3484d38..cad303a0c5edf5b8077dca2ba4f52c8352b3aeab 100644 (file)
--- a/test/orm/transaction.py
+++ b/test/orm/transaction.py
@@ -282,6 +282,19 @@ class SavepointTest(TransactionTest):
         assert u2.name == 'jack'
         self.assertEquals(s.query(User.name).order_by(User.id).all(), [('ed',), ('jack',)])
 
+    @testing.requires.savepoints
+    def test_savepoint_delete(self):
+        s = self.session()
+        u1 = User(name='ed')
+        s.add(u1)
+        s.commit()
+        self.assertEquals(s.query(User).filter_by(name='ed').count(), 1)
+        s.begin_nested()
+        s.delete(u1)
+        s.commit()
+        self.assertEquals(s.query(User).filter_by(name='ed').count(), 0)
+        s.commit()
+
     @testing.requires.savepoints
     def test_savepoint_commit(self):
         s = self.session()