Adjust benchtests to new support library.

This patch basically replaces the test-skeleton.c inclusion by
support/test-driver.c and also minor adjustments in bench-string.h.

Checked on x86_64-linux-gnu and powerpc64le-linux-gnu.

	* benchtests/bench-string.h (TEST_FUNCTION): Use name without
	parenthesis.
	(CMDLINE_PROCESS): Define using function instead of macro.
	* benchtests/bench-memccpy.c: Include <support/test-driver.c> instead
	of test-skeleton.
	* benchtests/bench-memchr.c: Likewise.
	* benchtests/bench-memcmp.c: Likewise.
	* benchtests/bench-memcpy-large.c: Likewise.
	* benchtests/bench-memcpy.c: Likewise.
	* benchtests/bench-memmem.c: Likewise.
	* benchtests/bench-memmove-large.c: Likewise.
	* benchtests/bench-memmove.c: Likewise.
	* benchtests/bench-memset-large.c: Likewise.
	* benchtests/bench-memset.c: Likewise.
	* benchtests/bench-rawmemchr.c: Likewise.
	* benchtests/bench-strcasecmp.c: Likewise.
	* benchtests/bench-strcasestr.c: Likewise.
	* benchtests/bench-strcat.c: Likewise.
	* benchtests/bench-strchr.c: Likewise.
	* benchtests/bench-strcmp.c: Likewise.
	* benchtests/bench-strcpy.c: Likewise.
	* benchtests/bench-strcpy_chk.c: Likewise.
	* benchtests/bench-strlen.c: Likewise.
	* benchtests/bench-strncasecmp.c: Likewise.
	* benchtests/bench-strncmp.c: Likewise.
	* benchtests/bench-strncpy.c: Likewise.
	* benchtests/bench-strnlen.c: Likewise.
	* benchtests/bench-strpbrk.c: Likewise.
	* benchtests/bench-strrchr.c: Likewise.
	* benchtests/bench-strsep.c: Likewise.
	* benchtests/bench-strspn.c: Likewise.
	* benchtests/bench-strstr.c: Likewise.
	* benchtests/bench-strtok.c: Likewise.

diff --git a/ChangeLog b/ChangeLog
index 6a273201137a9436c3f40705f3b357bb52d47aec..fdb68ea4daa3653e5c0dbdca62651012c24cca26 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,39 @@
+2016-12-19  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
+
+       * benchtests/bench-string.h (TEST_FUNCTION): Use name without
+       parenthesis.
+       (CMDLINE_PROCESS): Define using function instead of macro.
+       * benchtests/bench-memccpy.c: Include <support/test-driver.c> instead
+       of test-skeleton.
+       * benchtests/bench-memchr.c: Likewise.
+       * benchtests/bench-memcmp.c: Likewise.
+       * benchtests/bench-memcpy-large.c: Likewise.
+       * benchtests/bench-memcpy.c: Likewise.
+       * benchtests/bench-memmem.c: Likewise.
+       * benchtests/bench-memmove-large.c: Likewise.
+       * benchtests/bench-memmove.c: Likewise.
+       * benchtests/bench-memset-large.c: Likewise.
+       * benchtests/bench-memset.c: Likewise.
+       * benchtests/bench-rawmemchr.c: Likewise.
+       * benchtests/bench-strcasecmp.c: Likewise.
+       * benchtests/bench-strcasestr.c: Likewise.
+       * benchtests/bench-strcat.c: Likewise.
+       * benchtests/bench-strchr.c: Likewise.
+       * benchtests/bench-strcmp.c: Likewise.
+       * benchtests/bench-strcpy.c: Likewise.
+       * benchtests/bench-strcpy_chk.c: Likewise.
+       * benchtests/bench-strlen.c: Likewise.
+       * benchtests/bench-strncasecmp.c: Likewise.
+       * benchtests/bench-strncmp.c: Likewise.
+       * benchtests/bench-strncpy.c: Likewise.
+       * benchtests/bench-strnlen.c: Likewise.
+       * benchtests/bench-strpbrk.c: Likewise.
+       * benchtests/bench-strrchr.c: Likewise.
+       * benchtests/bench-strsep.c: Likewise.
+       * benchtests/bench-strspn.c: Likewise.
+       * benchtests/bench-strstr.c: Likewise.
+       * benchtests/bench-strtok.c: Likewise.
+
 2016-12-19  Andrew Senkevich  <andrew.senkevich@intel.com>
 
        * sysdeps/x86/cpu-features.c (get_common_indeces): Add

diff --git a/benchtests/bench-memccpy.c b/benchtests/bench-memccpy.c
index 00ac3e18a6e48ee7d1587cc94a211d2063641f4b..9be8fa07e6a7326d9275db4fb0633bad83dc14bb 100644 (file)
--- a/benchtests/bench-memccpy.c
+++ b/benchtests/bench-memccpy.c
@@ -160,4 +160,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-memchr.c b/benchtests/bench-memchr.c
index aa012f29100e8759cd9ff98108f2775f74f43ea2..7b8299a63a9b421a853b6d519d8f73c710c15e79 100644 (file)
--- a/benchtests/bench-memchr.c
+++ b/benchtests/bench-memchr.c
@@ -153,4 +153,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-memcmp.c b/benchtests/bench-memcmp.c
index 96d01a1e7c6c0188b8fd0cf6d9c91f4a4fa8ace5..4f01d3d2ae8bd37871efb505e619bb5f5c50d857 100644 (file)
--- a/benchtests/bench-memcmp.c
+++ b/benchtests/bench-memcmp.c
@@ -174,4 +174,5 @@ test_main (void)
 
   return ret;
 }
-#include "../test-skeleton.c"
+
+#include <support/test-driver.c>

diff --git a/benchtests/bench-memcpy-large.c b/benchtests/bench-memcpy-large.c
index 1ef670ed93a68eaf3c5fe36bb81763aaf98b5720..7be9930c054c73df156329e140c90f67e3b8945b 100644 (file)
--- a/benchtests/bench-memcpy-large.c
+++ b/benchtests/bench-memcpy-large.c
@@ -120,4 +120,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-memcpy.c b/benchtests/bench-memcpy.c
index 9d9e7b68790a8048312689b792a08a752c00cdf7..62e95c1eefb8df6e333b8b3c85ca8f065ebf33d0 100644 (file)
--- a/benchtests/bench-memcpy.c
+++ b/benchtests/bench-memcpy.c
@@ -166,4 +166,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-memmem.c b/benchtests/bench-memmem.c
index 863f02f7c02e94980f3e01948b4b4ffa6b476087..ab80990df184500f076d5c2258c054f9d7e6b2e8 100644 (file)
--- a/benchtests/bench-memmem.c
+++ b/benchtests/bench-memmem.c
@@ -161,4 +161,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-memmove-large.c b/benchtests/bench-memmove-large.c
index b8f11c1f193b2f53c1a731f74c5da502d5505a1e..840907bd84f43e4f198a395779af0b3d8bd0e907 100644 (file)
--- a/benchtests/bench-memmove-large.c
+++ b/benchtests/bench-memmove-large.c
@@ -120,4 +120,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-memmove.c b/benchtests/bench-memmove.c
index 3858f2ac52dcaca6600087cffd41fd1bbba383e8..9710863bae6c82303a8532f9d704e94eea43fdf9 100644 (file)
--- a/benchtests/bench-memmove.c
+++ b/benchtests/bench-memmove.c
@@ -139,7 +139,7 @@ do_test (size_t align1, size_t align2, size_t len)
   putchar ('\n');
 }
 
-int
+static int
 test_main (void)
 {
   size_t i;
@@ -188,4 +188,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-memset-large.c b/benchtests/bench-memset-large.c
index e694b929e840e732666ce05344267ebea95abdac..ede00812a57242bf07057519732a4a9bd42a480f 100644 (file)
--- a/benchtests/bench-memset-large.c
+++ b/benchtests/bench-memset-large.c
@@ -131,4 +131,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c
index 98ec257b3ee49b1e3d551b3c5a936c0bd808b364..d7abb44866ac777b4c238231c4c5750102b23cac 100644 (file)
--- a/benchtests/bench-memset.c
+++ b/benchtests/bench-memset.c
@@ -190,4 +190,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-rawmemchr.c b/benchtests/bench-rawmemchr.c
index 0c00c66e18b1bb5a8206969f8bdd127bc6a61753..9cf5d5b746cefd451bb9a26052b4f353489c5807 100644 (file)
--- a/benchtests/bench-rawmemchr.c
+++ b/benchtests/bench-rawmemchr.c
@@ -123,4 +123,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strcasecmp.c b/benchtests/bench-strcasecmp.c
index a9a748a151576a84cfc414cce0bf7cc6a41e2f37..7a84ab5ad7f6f9e5f6ef5bec7ef89736050a4d5d 100644 (file)
--- a/benchtests/bench-strcasecmp.c
+++ b/benchtests/bench-strcasecmp.c
@@ -173,4 +173,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strcasestr.c b/benchtests/bench-strcasestr.c
index bc58880fe0fa653a01fbff784919014b4e2f4693..11e1aadfd6c85493ae44201c1cc97cbbf5b01bf1 100644 (file)
--- a/benchtests/bench-strcasestr.c
+++ b/benchtests/bench-strcasestr.c
@@ -177,4 +177,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strcat.c b/benchtests/bench-strcat.c
index 4fc2806a9dedc8a809d333ae0151d27f30d86087..05207bee76bfc5b732fb8d7c3ec3531e14e40535 100644 (file)
--- a/benchtests/bench-strcat.c
+++ b/benchtests/bench-strcat.c
@@ -171,4 +171,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strchr.c b/benchtests/bench-strchr.c
index 6512085e9f8ffece59c41e6b358ade7147aa0003..7fc7c379097c40e2ad279214c5c0f6742377386c 100644 (file)
--- a/benchtests/bench-strchr.c
+++ b/benchtests/bench-strchr.c
@@ -207,4 +207,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strcmp.c b/benchtests/bench-strcmp.c
index f2d83c08b51e9b7abd1edd6179524c1f889a8bb4..8597c69bcce97e30b3d4f3adcd5d2c15a0acd4b5 100644 (file)
--- a/benchtests/bench-strcmp.c
+++ b/benchtests/bench-strcmp.c
@@ -238,4 +238,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strcpy.c b/benchtests/bench-strcpy.c
index 5517221862c2bb549ec4c59de6631a713e94dd02..a83566282c3596f6b571805814e2017d7dcddbde 100644 (file)
--- a/benchtests/bench-strcpy.c
+++ b/benchtests/bench-strcpy.c
@@ -190,4 +190,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strcpy_chk.c b/benchtests/bench-strcpy_chk.c
index ded674770262d0f118e321b993ae85a62ffc68a1..e987546301c204092d6658cd5574ad149cf246c4 100644 (file)
--- a/benchtests/bench-strcpy_chk.c
+++ b/benchtests/bench-strcpy_chk.c
@@ -53,8 +53,7 @@ simple_strcpy_chk (char *dst, const char *src, size_t len)
 #include <setjmp.h>
 #include <signal.h>
 
-static int test_main (void);
-#include "../test-skeleton.c"
+#include <support/support.h>
 
 volatile int chk_fail_ok;
 jmp_buf chk_fail_buf;
@@ -241,3 +240,5 @@ test_main (void)
 
   return 0;
 }
+
+#include <support/test-driver.c>

diff --git a/benchtests/bench-string.h b/benchtests/bench-string.h
index 9c5371ec77c4225b6d3ee1b2db9b8252dcf70efe..82cbe7a47dbc944836759ab23af55462764b01dd 100644 (file)
--- a/benchtests/bench-string.h
+++ b/benchtests/bench-string.h
@@ -16,6 +16,7 @@
    License along with the GNU C Library; if not, see
    <http://www.gnu.org/licenses/>.  */
 
+#include <getopt.h>
 #include <sys/cdefs.h>
 
 typedef struct
@@ -55,7 +56,7 @@ extern impl_t __start_impls[], __stop_impls[];
 # include "bench-timing.h"
 
 
-# define TEST_FUNCTION test_main ()
+# define TEST_FUNCTION test_main
 # ifndef TIMEOUT
 #  define TIMEOUT (4 * 60)
 # endif
@@ -87,24 +88,31 @@ size_t iterations = 100000;
 # define CMDLINE_OPTIONS ITERATIONS_OPTIONS \
     { "random", no_argument, NULL, OPT_RANDOM },                             \
     { "seed", required_argument, NULL, OPT_SEED },
-# define CMDLINE_PROCESS ITERATIONS_PROCESS \
-    case OPT_RANDOM:                                                         \
-      {                                                                              \
-       int fdr = open ("/dev/urandom", O_RDONLY);                            \
-                                                                             \
-       if (fdr < 0 || read (fdr, &seed, sizeof(seed)) != sizeof (seed))      \
-         seed = time (NULL);                                                 \
-       if (fdr >= 0)                                                         \
-         close (fdr);                                                        \
-       do_srandom = 1;                                                       \
-       break;                                                                \
-      }                                                                              \
-                                                                             \
-    case OPT_SEED:                                                           \
-      seed = strtoul (optarg, NULL, 0);                                              \
-      do_srandom = 1;                                                        \
-      break;
 
+static void __attribute__ ((used))
+cmdline_process_function (int c)
+{
+  switch (c)
+    {
+      ITERATIONS_PROCESS
+      case OPT_RANDOM:
+       {
+         int fdr = open ("/dev/urandom", O_RDONLY);
+         if (fdr < 0 || read (fdr, &seed, sizeof(seed)) != sizeof (seed))
+           seed = time (NULL);
+         if (fdr >= 0)
+           close (fdr);
+         do_srandom = 1;
+         break;
+       }
+
+      case OPT_SEED:
+       seed = strtoul (optarg, NULL, 0);
+       do_srandom = 1;
+      break;
+    }
+}
+# define CMDLINE_PROCESS cmdline_process_function
 # define CALL(impl, ...)       \
     (* (proto_t) (impl)->fn) (__VA_ARGS__)
 

diff --git a/benchtests/bench-strlen.c b/benchtests/bench-strlen.c
index a5305b544cf69f919f26c9200f09a4f1caf1fd01..f85405965dc0d63649426e6eadfd503795c01a49 100644 (file)
--- a/benchtests/bench-strlen.c
+++ b/benchtests/bench-strlen.c
@@ -139,4 +139,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strncasecmp.c b/benchtests/bench-strncasecmp.c
index 6cbab7d84df17fbf8f9f9ac635991449ccd65d8a..5570df24a69384104345f721403907099f1e2048 100644 (file)
--- a/benchtests/bench-strncasecmp.c
+++ b/benchtests/bench-strncasecmp.c
@@ -204,4 +204,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strncmp.c b/benchtests/bench-strncmp.c
index 2f03668f5e9ef9d528ac1660084a201a83d440eb..ac35c863320cb09fb0377b0c0f33b7df19ab3174 100644 (file)
--- a/benchtests/bench-strncmp.c
+++ b/benchtests/bench-strncmp.c
@@ -296,4 +296,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strncpy.c b/benchtests/bench-strncpy.c
index 5843571e45bcb8f86dcf182ea3615e7933fd99b3..916eedb871a4d2bbcf2e51f0164baed00122666a 100644 (file)
--- a/benchtests/bench-strncpy.c
+++ b/benchtests/bench-strncpy.c
@@ -172,7 +172,7 @@ do_test (size_t align1, size_t align2, size_t len, size_t n, int max_char)
   putchar ('\n');
 }
 
-int
+static int
 test_main (void)
 {
   size_t i;
@@ -207,4 +207,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strnlen.c b/benchtests/bench-strnlen.c
index f3dbf9713bd05138afaee5cf5c0f5e297a233428..794b994433ed6b7f103169bb3a8ce548ed0ebef1 100644 (file)
--- a/benchtests/bench-strnlen.c
+++ b/benchtests/bench-strnlen.c
@@ -150,4 +150,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strpbrk.c b/benchtests/bench-strpbrk.c
index 6591a83723aec804d536e79c91882e25114f3296..4647be76dd1edba249bb45ed075d4be9d930a8cf 100644 (file)
--- a/benchtests/bench-strpbrk.c
+++ b/benchtests/bench-strpbrk.c
@@ -203,4 +203,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strrchr.c b/benchtests/bench-strrchr.c
index ff936348b336ff811f6976957c3e340a6db6668c..f211a2ce78dd6c414f791d2ce82ea8f57d6d64d2 100644 (file)
--- a/benchtests/bench-strrchr.c
+++ b/benchtests/bench-strrchr.c
@@ -181,4 +181,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strsep.c b/benchtests/bench-strsep.c
index 70dbb377563232a43895abc940d396f2c65237c6..774a093431275670f6fd8ae6a8ceb7e3bb50a453 100644 (file)
--- a/benchtests/bench-strsep.c
+++ b/benchtests/bench-strsep.c
@@ -171,4 +171,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strspn.c b/benchtests/bench-strspn.c
index 606a8ddbdc0a821dd283d7c5e704de67ac7b5c1a..498b1409b8172dafa62730fb38feaf5aacee3539 100644 (file)
--- a/benchtests/bench-strspn.c
+++ b/benchtests/bench-strspn.c
@@ -189,4 +189,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strstr.c b/benchtests/bench-strstr.c
index 5e50e8e1729be5ab0fabaf2bc7f7cf54a32c85ed..b28685cb36db6195219e79f05982bb0335439608 100644 (file)
--- a/benchtests/bench-strstr.c
+++ b/benchtests/bench-strstr.c
@@ -174,4 +174,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>

diff --git a/benchtests/bench-strtok.c b/benchtests/bench-strtok.c
index 41e0e45db818428a3f3a940fa1a70ca3850e84b3..0c3bfe1830293a1878bc410da48f5dc046974ddc 100644 (file)
--- a/benchtests/bench-strtok.c
+++ b/benchtests/bench-strtok.c
@@ -177,4 +177,4 @@ test_main (void)
   return ret;
 }
 
-#include "../test-skeleton.c"
+#include <support/test-driver.c>