]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
m4/dovecot.m4: rename valgrind output file to hide it from certain tests
authorPhil Carmody <phil@dovecot.fi>
Tue, 19 Jun 2018 12:30:36 +0000 (15:30 +0300)
committerTimo Sirainen <timo.sirainen@open-xchange.com>
Fri, 15 Feb 2019 12:48:56 +0000 (12:48 +0000)
Some lib-http tests use readdir() to create test cases, and sometimes
object to the contents of test.out.$$. However, as lib-http is also
sensitive to certain characters in the filenames of the files it uses,
we can hide the valgrind output by chosing its filename to exclude it
from the lib_http tests. Non-initial '~' is not known to cause any issues
for either the shell or any known operating system, so is the safest of
lib-http's 'dodgy' characters to use as the separator.

Signed-off-by: Phil Carmody <phil@dovecot.fi>
m4/dovecot.m4

index 149105e9c640ff08e7d742847d00647cf31e9b94..980f6309b9bdf67bc35ab912a6eb377b3dcf6312 100644 (file)
@@ -285,7 +285,7 @@ if test "\$NOVALGRIND" != ""; then
   \$[*]
   ret=\$?
 else
-  test_out="test.out.\$\$"
+  test_out="test.out~\$\$"
   trap "rm -f \$test_out" 0 1 2 3 15
   supp_path="\$top_srcdir/run-test-valgrind.supp"
   if test -r "\$supp_path"; then