]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
md/raid1-10: fix casting from randomized structure in raid1_submit_write()
authorYu Kuai <yukuai3@huawei.com>
Fri, 16 Jun 2023 01:21:36 +0000 (09:21 +0800)
committerSong Liu <song@kernel.org>
Fri, 23 Jun 2023 16:33:16 +0000 (09:33 -0700)
Following build error triggered while build with clang version 17.0.0
with W=1(this can't be reporduced with gcc 13.1.0):

drivers/md/raid1-10.c:117:25: error: casting from randomized structure
pointer type 'struct block_device *' to 'struct md_rdev *'
     117 |         struct md_rdev *rdev = (struct md_rdev *)bio->bi_bdev;
         |                                ^

Fix this by casting 'bio->bi_bdev' to 'void *', as it used to be.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202306142042.fmjfmTF8-lkp@intel.com/
Fixes: 8295efbe68c0 ("md/raid1-10: factor out a helper to submit normal write")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20230616012136.3047071-1-yukuai1@huaweicloud.com
drivers/md/raid1-10.c

index 169ebe296f2d0cdb433a83676bbcdcd5100494c4..3f22edec70e7845f68697399676038adf879d90f 100644 (file)
@@ -116,7 +116,7 @@ static void md_bio_reset_resync_pages(struct bio *bio, struct resync_pages *rp,
 
 static inline void raid1_submit_write(struct bio *bio)
 {
-       struct md_rdev *rdev = (struct md_rdev *)bio->bi_bdev;
+       struct md_rdev *rdev = (void *)bio->bi_bdev;
 
        bio->bi_next = NULL;
        bio_set_dev(bio, rdev->bdev);