ACPI: CPPC: Extract cppc_get_reg_val_in_pcc()

Extract the operations if register is in pcc out from cppc_get_reg_val()
as cppc_get_reg_val_in_pcc().

Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
Signed-off-by: Lifeng Zheng <zhenglifeng1@huawei.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://patch.msgid.link/20250411093855.982491-5-zhenglifeng1@huawei.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
index c460272b86c3d9448ed00088922e69afbb5898da..14dd206b4454d83daaab46ae12241fa4ae0e9d05 100644 (file)
--- a/drivers/acpi/cppc_acpi.c
+++ b/drivers/acpi/cppc_acpi.c
@@ -1179,6 +1179,31 @@ static int cpc_write(int cpu, struct cpc_register_resource *reg_res, u64 val)
        return ret_val;
 }
 
+static int cppc_get_reg_val_in_pcc(int cpu, struct cpc_register_resource *reg, u64 *val)
+{
+       int pcc_ss_id = per_cpu(cpu_pcc_subspace_idx, cpu);
+       struct cppc_pcc_data *pcc_ss_data = NULL;
+       int ret;
+
+       if (pcc_ss_id < 0) {
+               pr_debug("Invalid pcc_ss_id\n");
+               return -ENODEV;
+       }
+
+       pcc_ss_data = pcc_data[pcc_ss_id];
+
+       down_write(&pcc_ss_data->pcc_lock);
+
+       if (send_pcc_cmd(pcc_ss_id, CMD_READ) >= 0)
+               ret = cpc_read(cpu, reg, val);
+       else
+               ret = -EIO;
+
+       up_write(&pcc_ss_data->pcc_lock);
+
+       return ret;
+}
+
 static int cppc_get_reg_val(int cpu, enum cppc_regs reg_idx, u64 *val)
 {
        struct cpc_desc *cpc_desc = per_cpu(cpc_desc_ptr, cpu);
@@ -1201,29 +1226,8 @@ static int cppc_get_reg_val(int cpu, enum cppc_regs reg_idx, u64 *val)
                return -EOPNOTSUPP;
        }
 
-       if (CPC_IN_PCC(reg)) {
-               int pcc_ss_id = per_cpu(cpu_pcc_subspace_idx, cpu);
-               struct cppc_pcc_data *pcc_ss_data = NULL;
-               int ret;
-
-               if (pcc_ss_id < 0) {
-                       pr_debug("Invalid pcc_ss_id\n");
-                       return -ENODEV;
-               }
-
-               pcc_ss_data = pcc_data[pcc_ss_id];
-
-               down_write(&pcc_ss_data->pcc_lock);
-
-               if (send_pcc_cmd(pcc_ss_id, CMD_READ) >= 0)
-                       ret = cpc_read(cpu, reg, val);
-               else
-                       ret = -EIO;
-
-               up_write(&pcc_ss_data->pcc_lock);
-
-               return ret;
-       }
+       if (CPC_IN_PCC(reg))
+               return cppc_get_reg_val_in_pcc(cpu, reg, val);
 
        return cpc_read(cpu, reg, val);
 }