gdb/configure: fail configure if all targets requested with 32bit bfd

As PR sim/28684 explains, it isn't possible to compile GDB with all
targets enabled and not enabling 64 bit bfd. In 64 bit hosts, 64 bit bfd
is forced, so the build works, but in 32 bit hosts, that has to be
explicitly enabled.

I ran into this when I tried compiling GDB on a mips64 machine running a
32 bit OS. Along with the errors in the PR, several other architectures
are also required, notably aarch64 and other explicitly 64bit targets.
Additionally, some 32 bit files required for the gdb mips target aren't
added to the makefile.

Considering the last comment in the bug says this isn't going to be
fixed on the binutils side, I didn't think it was worth trying to fix
the GDB side. Instead, this commit causes the configure script to fail
if all targets were requested and 64 bit bfd isn't enabled. If that is
ever fixed, we can revert this commit.

I considered adding this to the top level configure script, but couldn't
figure out how to detect the situation in there, so this was my next
best idea.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28684
Approved-by: Kevin Buettner <kevinb@redhat.com>

diff --git a/gdb/configure b/gdb/configure
index 1531f62f76a0e23d7d181e0781f179d9924e0f72..cfb4f446ef8c96d6b8c919c64121b269fd06170a 100755 (executable)
--- a/gdb/configure
+++ b/gdb/configure
@@ -25005,7 +25005,9 @@ if test x${all_targets} = xtrue; then
   if test x${enable_64_bit_bfd} = xyes; then
     TARGET_OBS='$(ALL_TARGET_OBS) $(ALL_64_TARGET_OBS)'
   else
-    TARGET_OBS='$(ALL_TARGET_OBS)'
+    # If all targets were requested, but 64 bit bfd is not enabled,
+    # the build will fail. See PR 28684.
+    as_fn_error $? "--enable-targets=all requires --enable-64-bit-bfd" "$LINENO" 5
   fi
 fi
 

diff --git a/gdb/configure.ac b/gdb/configure.ac
index e9312b1bc64d90b86c4f237c94caa1e708b71cdd..77f774e23ee066c8b758fbb7aed822f209bca141 100644 (file)
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -257,7 +257,9 @@ if test x${all_targets} = xtrue; then
   if test x${enable_64_bit_bfd} = xyes; then
     TARGET_OBS='$(ALL_TARGET_OBS) $(ALL_64_TARGET_OBS)'
   else
-    TARGET_OBS='$(ALL_TARGET_OBS)'
+    # If all targets were requested, but 64 bit bfd is not enabled,
+    # the build will fail. See PR 28684.
+    AC_MSG_ERROR([--enable-targets=all requires --enable-64-bit-bfd])
   fi
 fi