]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
btrfs: fix placement of unlikely() in btrfs_insert_one_raid_extent()
authorMark Harmstone <mark@harmstone.com>
Wed, 18 Feb 2026 12:41:00 +0000 (12:41 +0000)
committerDavid Sterba <dsterba@suse.com>
Tue, 7 Apr 2026 16:55:58 +0000 (18:55 +0200)
Fix the unlikely added to btrfs_insert_one_raid_extent() by commit
a929904cf73b65 ("btrfs: add unlikely annotations to branches leading to
transaction abort"): the exclamation point is in the wrong place, so we
are telling the compiler that allocation failure is actually expected.

Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Mark Harmstone <mark@harmstone.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/raid-stripe-tree.c

index 2987cb7c686eabb21fc0adc5bc8fae371679a94b..638c4ad572c9963d588b88c4bbe0b27ea53e0c1e 100644 (file)
@@ -300,7 +300,7 @@ int btrfs_insert_one_raid_extent(struct btrfs_trans_handle *trans,
        int ret;
 
        stripe_extent = kzalloc(item_size, GFP_NOFS);
-       if (!unlikely(stripe_extent)) {
+       if (unlikely(!stripe_extent)) {
                btrfs_abort_transaction(trans, -ENOMEM);
                btrfs_end_transaction(trans);
                return -ENOMEM;